| Message ID | 1494948714-15203-3-git-send-email-ckeepax@opensource.wolfsonmicro.com |
|---|---|
| State | New |
| Headers | show |
On Tue, 16 May 2017, Charles Keepax wrote: > Update the device tree binding to show that the new GPIO_SLEEP flags are > now supported in the flags field of the GPIO binding for Arizona > devices. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > Documentation/devicetree/bindings/mfd/arizona.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > index 8f2e282..1729133 100644 > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > @@ -30,7 +30,10 @@ Required properties: > > - gpio-controller : Indicates this device is a GPIO controller. > - #gpio-cells : Must be 2. The first cell is the pin number and the > - second cell is used to specify optional parameters (currently unused). > + second cell is used to specify optional parameters, the following flags > + are supported: > + "GPIO_SLEEP_MAY_LOOSE_OUTPUT" the output of this GPIO does not need to > + be maintained whilst the CODEC is in low power mode. I guess this needs a GPIO and DT Ack.
On Mon, 22 May 2017, Lee Jones wrote: > On Tue, 16 May 2017, Charles Keepax wrote: > > > Update the device tree binding to show that the new GPIO_SLEEP flags are > > now supported in the flags field of the GPIO binding for Arizona > > devices. > > > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > > --- > > Documentation/devicetree/bindings/mfd/arizona.txt | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > > index 8f2e282..1729133 100644 > > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > > @@ -30,7 +30,10 @@ Required properties: > > > > - gpio-controller : Indicates this device is a GPIO controller. > > - #gpio-cells : Must be 2. The first cell is the pin number and the > > - second cell is used to specify optional parameters (currently unused). > > + second cell is used to specify optional parameters, the following flags > > + are supported: > > + "GPIO_SLEEP_MAY_LOOSE_OUTPUT" the output of this GPIO does not need to > > + be maintained whilst the CODEC is in low power mode. > > I guess this needs a GPIO and DT Ack. FYI, if you receive both of those, you can also add mine without any further intervention from me.
On Tue, May 16, 2017 at 04:31:54PM +0100, Charles Keepax wrote: > Update the device tree binding to show that the new GPIO_SLEEP flags are > now supported in the flags field of the GPIO binding for Arizona > devices. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > Documentation/devicetree/bindings/mfd/arizona.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 16, 2017 at 5:31 PM, Charles Keepax <ckeepax@opensource.wolfsonmicro.com> wrote: > Update the device tree binding to show that the new GPIO_SLEEP flags are > now supported in the flags field of the GPIO binding for Arizona > devices. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> (...) > - gpio-controller : Indicates this device is a GPIO controller. > - #gpio-cells : Must be 2. The first cell is the pin number and the > - second cell is used to specify optional parameters (currently unused). > + second cell is used to specify optional parameters, the following flags > + are supported: > + "GPIO_SLEEP_MAY_LOOSE_OUTPUT" the output of this GPIO does not need to > + be maintained whilst the CODEC is in low power mode. Your gpio controller most definately support more options than that, for example open drain. But it is supposed to be a generic property so instead patch gpio.txt and reference that file from here. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 23, 2017 at 10:49:23AM +0200, Linus Walleij wrote: > On Tue, May 16, 2017 at 5:31 PM, Charles Keepax > <ckeepax@opensource.wolfsonmicro.com> wrote: > > > Update the device tree binding to show that the new GPIO_SLEEP flags are > > now supported in the flags field of the GPIO binding for Arizona > > devices. > > > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > (...) > > - gpio-controller : Indicates this device is a GPIO controller. > > - #gpio-cells : Must be 2. The first cell is the pin number and the > > - second cell is used to specify optional parameters (currently unused). > > + second cell is used to specify optional parameters, the following flags > > + are supported: > > + "GPIO_SLEEP_MAY_LOOSE_OUTPUT" the output of this GPIO does not need to > > + be maintained whilst the CODEC is in low power mode. > > Your gpio controller most definately support more options than that, > for example open drain. > Not at the moment, there are potentially a few more things we could support with the hardware though. > But it is supposed to be a generic property so instead patch gpio.txt > and reference that file from here. > Yeah happy to move it over there. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt index 8f2e282..1729133 100644 --- a/Documentation/devicetree/bindings/mfd/arizona.txt +++ b/Documentation/devicetree/bindings/mfd/arizona.txt @@ -30,7 +30,10 @@ Required properties: - gpio-controller : Indicates this device is a GPIO controller. - #gpio-cells : Must be 2. The first cell is the pin number and the - second cell is used to specify optional parameters (currently unused). + second cell is used to specify optional parameters, the following flags + are supported: + "GPIO_SLEEP_MAY_LOOSE_OUTPUT" the output of this GPIO does not need to + be maintained whilst the CODEC is in low power mode. - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device, as covered in Documentation/devicetree/bindings/regulator/regulator.txt
Update the device tree binding to show that the new GPIO_SLEEP flags are now supported in the flags field of the GPIO binding for Arizona devices. Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> --- Documentation/devicetree/bindings/mfd/arizona.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)