| Message ID | 1288235555-24675-2-git-send-email-harvey.harrison@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Thanks. Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com> On Wed, 27 Oct 2010, Harvey Harrison wrote: > Noticed by sparse: > drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16 > drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16 > drivers/net/vmxnet3/vmxnet3_drv.c:876:24: warning: restricted __be16 degrades to integer > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> > --- > drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c > index e3658e1..21314e0 100644 > --- a/drivers/net/vmxnet3/vmxnet3_drv.c > +++ b/drivers/net/vmxnet3/vmxnet3_drv.c > @@ -873,7 +873,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq, > count = VMXNET3_TXD_NEEDED(skb_headlen(skb)) + > skb_shinfo(skb)->nr_frags + 1; > > - ctx.ipv4 = (skb->protocol == __constant_ntohs(ETH_P_IP)); > + ctx.ipv4 = (skb->protocol == cpu_to_be16(ETH_P_IP)); > > ctx.mss = skb_shinfo(skb)->gso_size; > if (ctx.mss) { > -- > 1.7.1 > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Harvey Harrison <harvey.harrison@gmail.com> Date: Wed, 27 Oct 2010 20:12:35 -0700 > Noticed by sparse: > drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16 > drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16 > drivers/net/vmxnet3/vmxnet3_drv.c:876:24: warning: restricted __be16 degrades to integer > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index e3658e1..21314e0 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -873,7 +873,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq, count = VMXNET3_TXD_NEEDED(skb_headlen(skb)) + skb_shinfo(skb)->nr_frags + 1; - ctx.ipv4 = (skb->protocol == __constant_ntohs(ETH_P_IP)); + ctx.ipv4 = (skb->protocol == cpu_to_be16(ETH_P_IP)); ctx.mss = skb_shinfo(skb)->gso_size; if (ctx.mss) {
Noticed by sparse: drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16 drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16 drivers/net/vmxnet3/vmxnet3_drv.c:876:24: warning: restricted __be16 degrades to integer Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)