diff mbox

mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE_TEST

Message ID 861b57d26929934bfc99e8db691a483ee1e2cada.1493926168.git.cyrille.pitchen@wedev4u.fr
State Accepted
Commit ecca81f8cb54ce74f3d5d4ba77732a216173f7b1
Delegated to: Cyrille Pitchen
Headers show

Commit Message

Cyrille Pitchen May 4, 2017, 7:39 p.m. UTC
This patch fixes some compiler errors:
- change format strings to use %zx for size_t
- add missing #include <linux/sizes.h>

Cc: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
---
 drivers/mtd/spi-nor/stm32-quadspi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Ludovic Barre May 5, 2017, 7:36 a.m. UTC | #1
On 05/04/2017 09:39 PM, Cyrille Pitchen wrote:
> This patch fixes some compiler errors:
> - change format strings to use %zx for size_t
> - add missing #include <linux/sizes.h>
>
> Cc: Ludovic Barre <ludovic.barre@st.com>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> ---
>   drivers/mtd/spi-nor/stm32-quadspi.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
> index 1056e7408d2a..86c0931543c5 100644
> --- a/drivers/mtd/spi-nor/stm32-quadspi.c
> +++ b/drivers/mtd/spi-nor/stm32-quadspi.c
> @@ -19,6 +19,7 @@
>   #include <linux/of_device.h>
>   #include <linux/platform_device.h>
>   #include <linux/reset.h>
> +#include <linux/sizes.h>
>   
>   #define QUADSPI_CR		0x00
>   #define CR_EN			BIT(0)
> @@ -375,7 +376,7 @@ static ssize_t stm32_qspi_read(struct spi_nor *nor, loff_t from, size_t len,
>   	struct stm32_qspi_cmd cmd;
>   	int err;
>   
> -	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#x\n",
> +	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#zx\n",
>   		nor->read_opcode, buf, (u32)from, len);
>   
>   	memset(&cmd, 0, sizeof(cmd));
> @@ -402,7 +403,7 @@ static ssize_t stm32_qspi_write(struct spi_nor *nor, loff_t to, size_t len,
>   	struct stm32_qspi_cmd cmd;
>   	int err;
>   
> -	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#x\n",
> +	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#zx\n",
>   		nor->program_opcode, buf, (u32)to, len);
>   
>   	memset(&cmd, 0, sizeof(cmd));
Reviewed-by: Ludovic Barre <ludovic.barre@st.com>
Cyrille Pitchen May 10, 2017, 9:49 a.m. UTC | #2
Le 04/05/2017 à 21:39, Cyrille Pitchen a écrit :
> This patch fixes some compiler errors:
> - change format strings to use %zx for size_t
> - add missing #include <linux/sizes.h>
> 
> Cc: Ludovic Barre <ludovic.barre@st.com>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>

Applied to the github/spi-nor tree


> ---
>  drivers/mtd/spi-nor/stm32-quadspi.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
> index 1056e7408d2a..86c0931543c5 100644
> --- a/drivers/mtd/spi-nor/stm32-quadspi.c
> +++ b/drivers/mtd/spi-nor/stm32-quadspi.c
> @@ -19,6 +19,7 @@
>  #include <linux/of_device.h>
>  #include <linux/platform_device.h>
>  #include <linux/reset.h>
> +#include <linux/sizes.h>
>  
>  #define QUADSPI_CR		0x00
>  #define CR_EN			BIT(0)
> @@ -375,7 +376,7 @@ static ssize_t stm32_qspi_read(struct spi_nor *nor, loff_t from, size_t len,
>  	struct stm32_qspi_cmd cmd;
>  	int err;
>  
> -	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#x\n",
> +	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#zx\n",
>  		nor->read_opcode, buf, (u32)from, len);
>  
>  	memset(&cmd, 0, sizeof(cmd));
> @@ -402,7 +403,7 @@ static ssize_t stm32_qspi_write(struct spi_nor *nor, loff_t to, size_t len,
>  	struct stm32_qspi_cmd cmd;
>  	int err;
>  
> -	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#x\n",
> +	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#zx\n",
>  		nor->program_opcode, buf, (u32)to, len);
>  
>  	memset(&cmd, 0, sizeof(cmd));
>
diff mbox

Patch

diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
index 1056e7408d2a..86c0931543c5 100644
--- a/drivers/mtd/spi-nor/stm32-quadspi.c
+++ b/drivers/mtd/spi-nor/stm32-quadspi.c
@@ -19,6 +19,7 @@ 
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/reset.h>
+#include <linux/sizes.h>
 
 #define QUADSPI_CR		0x00
 #define CR_EN			BIT(0)
@@ -375,7 +376,7 @@  static ssize_t stm32_qspi_read(struct spi_nor *nor, loff_t from, size_t len,
 	struct stm32_qspi_cmd cmd;
 	int err;
 
-	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#x\n",
+	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#zx\n",
 		nor->read_opcode, buf, (u32)from, len);
 
 	memset(&cmd, 0, sizeof(cmd));
@@ -402,7 +403,7 @@  static ssize_t stm32_qspi_write(struct spi_nor *nor, loff_t to, size_t len,
 	struct stm32_qspi_cmd cmd;
 	int err;
 
-	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#x\n",
+	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#zx\n",
 		nor->program_opcode, buf, (u32)to, len);
 
 	memset(&cmd, 0, sizeof(cmd));