| Message ID | 1493426498-5839-5-git-send-email-eddie.cai.linux@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Łukasz Majewski |
| Headers | show |
On 28 April 2017 at 18:41, Eddie Cai <eddie.cai.linux@gmail.com> wrote: > all rk3288 based boards support rockusb, so enable it > > Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> > > Changes in v3: > -move to defconfig > --- > configs/evb-rk3288_defconfig | 3 +++ > configs/fennec-rk3288_defconfig | 2 ++ > configs/firefly-rk3288_defconfig | 2 ++ > configs/miqi-rk3288_defconfig | 2 ++ > configs/popmetal-rk3288_defconfig | 2 ++ > configs/rock2_defconfig | 3 +++ > configs/sandbox_defconfig | 3 ++- > configs/tinker-rk3288_defconfig | 2 ++ > 8 files changed, 18 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> I wonder if you could make it default to y in Kconfig?
2017-04-30 11:49 GMT+08:00 Simon Glass <sjg@chromium.org>: > On 28 April 2017 at 18:41, Eddie Cai <eddie.cai.linux@gmail.com> wrote: >> all rk3288 based boards support rockusb, so enable it >> >> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> >> >> Changes in v3: >> -move to defconfig >> --- >> configs/evb-rk3288_defconfig | 3 +++ >> configs/fennec-rk3288_defconfig | 2 ++ >> configs/firefly-rk3288_defconfig | 2 ++ >> configs/miqi-rk3288_defconfig | 2 ++ >> configs/popmetal-rk3288_defconfig | 2 ++ >> configs/rock2_defconfig | 3 +++ >> configs/sandbox_defconfig | 3 ++- >> configs/tinker-rk3288_defconfig | 2 ++ >> 8 files changed, 18 insertions(+), 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> Thanks SImon > > I wonder if you could make it default to y in Kconfig? Good idea. i will add it in next version
diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig index aad2533..e380988 100644 --- a/configs/evb-rk3288_defconfig +++ b/configs/evb-rk3288_defconfig @@ -17,6 +17,9 @@ CONFIG_CMD_MMC=y CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y +CONFIG_CMD_USB=y +CONFIG_CMD_ROCKUSB=y +CONFIG_USB_FUNCTION_ROCKUSB=y CONFIG_CMD_GPIO=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_CACHE=y diff --git a/configs/fennec-rk3288_defconfig b/configs/fennec-rk3288_defconfig index d1b0ffc..6f0a2de 100644 --- a/configs/fennec-rk3288_defconfig +++ b/configs/fennec-rk3288_defconfig @@ -18,6 +18,8 @@ CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y CONFIG_CMD_USB=y +CONFIG_CMD_ROCKUSB=y +CONFIG_USB_FUNCTION_ROCKUSB=y CONFIG_CMD_GPIO=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_CACHE=y diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig index b0741d7..b2c2c72 100644 --- a/configs/firefly-rk3288_defconfig +++ b/configs/firefly-rk3288_defconfig @@ -17,6 +17,8 @@ CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y CONFIG_CMD_USB=y +CONFIG_CMD_ROCKUSB=y +CONFIG_USB_FUNCTION_ROCKUSB=y CONFIG_CMD_GPIO=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_CACHE=y diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig index 203824b..278b690 100644 --- a/configs/miqi-rk3288_defconfig +++ b/configs/miqi-rk3288_defconfig @@ -17,6 +17,8 @@ CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y CONFIG_CMD_USB=y +CONFIG_CMD_ROCKUSB=y +CONFIG_USB_FUNCTION_ROCKUSB=y CONFIG_CMD_GPIO=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_CACHE=y diff --git a/configs/popmetal-rk3288_defconfig b/configs/popmetal-rk3288_defconfig index dfc84b9..5f7cdee 100644 --- a/configs/popmetal-rk3288_defconfig +++ b/configs/popmetal-rk3288_defconfig @@ -18,6 +18,8 @@ CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y CONFIG_CMD_USB=y +CONFIG_CMD_ROCKUSB=y +CONFIG_USB_FUNCTION_ROCKUSB=y CONFIG_CMD_GPIO=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_CACHE=y diff --git a/configs/rock2_defconfig b/configs/rock2_defconfig index e9a32a9..accf14c 100644 --- a/configs/rock2_defconfig +++ b/configs/rock2_defconfig @@ -16,6 +16,9 @@ CONFIG_CMD_MMC=y CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y +CONFIG_CMD_USB=y +CONFIG_CMD_ROCKUSB=y +CONFIG_USB_FUNCTION_ROCKUSB=y CONFIG_CMD_GPIO=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_CACHE=y diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 9814ea3..707f0d6 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig @@ -33,7 +33,8 @@ CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y CONFIG_CMD_USB=y -CONFIG_CMD_REMOTEPROC=y +CONFIG_CMD_ROCKUSB=y +CONFIG_USB_FUNCTION_ROCKUSB=y CONFIG_CMD_GPIO=y CONFIG_CMD_TFTPPUT=y CONFIG_CMD_TFTPSRV=y diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index cec3938..2b0e2c8 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig @@ -18,6 +18,8 @@ CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y CONFIG_CMD_USB=y +CONFIG_CMD_ROCKUSB=y +CONFIG_USB_FUNCTION_ROCKUSB=y CONFIG_CMD_GPIO=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_CACHE=y
all rk3288 based boards support rockusb, so enable it Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com> Changes in v3: -move to defconfig --- configs/evb-rk3288_defconfig | 3 +++ configs/fennec-rk3288_defconfig | 2 ++ configs/firefly-rk3288_defconfig | 2 ++ configs/miqi-rk3288_defconfig | 2 ++ configs/popmetal-rk3288_defconfig | 2 ++ configs/rock2_defconfig | 3 +++ configs/sandbox_defconfig | 3 ++- configs/tinker-rk3288_defconfig | 2 ++ 8 files changed, 18 insertions(+), 1 deletion(-)