Message ID | 1288088743-3725-8-git-send-email-julia@diku.dk |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Tue, 2010-10-26 at 12:25 +0200, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Delete successive assignments to the same location. The current definition > does not initialize the respRing structure, which has the same type as the > cmdRing structure, so initialize that one instead. > Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: David Dillow <dave@thedillows.org> > --- > This changes the semantics and has not been tested. tp->respRing.lastWrite is only an artifact of using a common struct for the rings and is not otherwise used, so no change to semantics. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Julia Lawall <julia@diku.dk> Date: Tue, 26 Oct 2010 12:25:36 +0200 > From: Julia Lawall <julia@diku.dk> > > Delete successive assignments to the same location. The current definition > does not initialize the respRing structure, which has the same type as the > cmdRing structure, so initialize that one instead. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall <julia@diku.dk> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index 1cc6713..fc014eb 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c @@ -1328,7 +1328,7 @@ typhoon_init_rings(struct typhoon *tp) tp->rxHiRing.lastWrite = 0; tp->rxBuffRing.lastWrite = 0; tp->cmdRing.lastWrite = 0; - tp->cmdRing.lastWrite = 0; + tp->respRing.lastWrite = 0; tp->txLoRing.lastRead = 0; tp->txHiRing.lastRead = 0;