| Message ID | 1492180397-11896-1-git-send-email-xypron.glpk@gmx.de |
|---|---|
| State | Superseded |
| Delegated to: | Minkyu Kang |
| Headers | show |
Am 14.04.2017 um 16:33 schrieb Heinrich Schuchardt: > To enable automatic booting from SD card or eMMC the MMC devices 0 and 1 > are added to the BOOT_TARGET_DEVICES. > > Booting from SD card, eMMC, and DHCP are tried in sequence. > A missing or failing device is gracefully handled. > > Cc: Andreas Färber <afaerber@suse.de> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > v2: > Enhance commit message to clearly indicate how the > boot targets are sequenced. Reviewed-by: Andreas Färber <afaerber@suse.de> Thanks, Andreas
Am 14.04.2017 um 16:35 schrieb Andreas Färber: > Am 14.04.2017 um 16:33 schrieb Heinrich Schuchardt: >> To enable automatic booting from SD card or eMMC the MMC devices 0 and 1 >> are added to the BOOT_TARGET_DEVICES. >> >> Booting from SD card, eMMC, and DHCP are tried in sequence. >> A missing or failing device is gracefully handled. >> >> Cc: Andreas Färber <afaerber@suse.de> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> --- >> v2: >> Enhance commit message to clearly indicate how the >> boot targets are sequenced. > > Reviewed-by: Andreas Färber <afaerber@suse.de> As pointed out by Heiner, while this works for the Odroid-C2, hardcoding these two devices for GXBB blocks booting from eMMC where that shows up as mmc2. So either this should be defined on the odroid-c2 level, so that we can have board-specific device lists, or include mmc2 here as well. There might also be devices with only one. Regards, Andreas
diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h index cc2b5b6..388f239 100644 --- a/include/configs/meson-gxbb-common.h +++ b/include/configs/meson-gxbb-common.h @@ -39,6 +39,8 @@ #include <config_distro_defaults.h> #define BOOT_TARGET_DEVICES(func) \ + func(MMC, mmc, 0) \ + func(MMC, mmc, 1) \ func(DHCP, dhcp, na) #include <config_distro_bootcmd.h>
To enable automatic booting from SD card or eMMC the MMC devices 0 and 1 are added to the BOOT_TARGET_DEVICES. Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled. Cc: Andreas Färber <afaerber@suse.de> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- v2: Enhance commit message to clearly indicate how the boot targets are sequenced. v1: This is a resubmission of https://lists.denx.de/pipermail/u-boot/2017-April/287315.html where this patch was part of patch series which was no longer applicable. --- include/configs/meson-gxbb-common.h | 2 ++ 1 file changed, 2 insertions(+)