| Message ID | b7d2c034-42ad-f845-d9c0-5c697f763870@gmail.com |
|---|---|
| State | Deferred |
| Delegated to: | Jaehoon Chung |
| Headers | show |
Am 14.04.2017 um 10:24 schrieb Heiner Kallweit: > In most cases Odroid C2 is used with a eMMC card. So far the eMMC slot > was assigned dev number 1 (0 is the SD slot). So on uboot prompt U-Boot > we had to manually switch the mmc device first. Therefore change the > device number assignment. Objection, this differs from Linux and will be overwritten on next dts sync. Regards, Andreas > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > arch/arm/dts/meson-gxbb-odroidc2.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts > index c737183..5ec67ca 100644 > --- a/arch/arm/dts/meson-gxbb-odroidc2.dts > +++ b/arch/arm/dts/meson-gxbb-odroidc2.dts > @@ -53,6 +53,8 @@ > > aliases { > serial0 = &uart_AO; > + mmc0 = &sd_emmc_c; > + mmc1 = &sd_emmc_b; > }; > > chosen { >
Am 14.04.2017 um 15:39 schrieb Andreas Färber: > Am 14.04.2017 um 10:24 schrieb Heiner Kallweit: >> In most cases Odroid C2 is used with a eMMC card. So far the eMMC slot >> was assigned dev number 1 (0 is the SD slot). So on uboot prompt > > U-Boot > >> we had to manually switch the mmc device first. Therefore change the >> device number assignment. > > Objection, this differs from Linux and will be overwritten on next dts sync. > That's true .. From my perspective best solution would be if U-Boot wouldn't assign a device id at all to a SD slot w/o card inserted. However it seems like the current mmc core doesn't support this. Rgds, Heiner > Regards, > Andreas > >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> --- >> arch/arm/dts/meson-gxbb-odroidc2.dts | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts >> index c737183..5ec67ca 100644 >> --- a/arch/arm/dts/meson-gxbb-odroidc2.dts >> +++ b/arch/arm/dts/meson-gxbb-odroidc2.dts >> @@ -53,6 +53,8 @@ >> >> aliases { >> serial0 = &uart_AO; >> + mmc0 = &sd_emmc_c; >> + mmc1 = &sd_emmc_b; >> }; >> >> chosen { >> > >
Am 14.04.2017 um 17:52 schrieb Heiner Kallweit: > Am 14.04.2017 um 15:39 schrieb Andreas Färber: >> Am 14.04.2017 um 10:24 schrieb Heiner Kallweit: >>> In most cases Odroid C2 is used with a eMMC card. So far the eMMC slot >>> was assigned dev number 1 (0 is the SD slot). So on uboot prompt >> >> U-Boot >> >>> we had to manually switch the mmc device first. Therefore change the >>> device number assignment. >> >> Objection, this differs from Linux and will be overwritten on next dts sync. >> > That's true .. From my perspective best solution would be if U-Boot wouldn't > assign a device id at all to a SD slot w/o card inserted. > However it seems like the current mmc core doesn't support this. It is perfectly valid to not have an SD card in the slot and then to run "mmc rescan" after inserting one. So the device should definitely not be hidden. Regards, Andreas
diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts index c737183..5ec67ca 100644 --- a/arch/arm/dts/meson-gxbb-odroidc2.dts +++ b/arch/arm/dts/meson-gxbb-odroidc2.dts @@ -53,6 +53,8 @@ aliases { serial0 = &uart_AO; + mmc0 = &sd_emmc_c; + mmc1 = &sd_emmc_b; }; chosen {
In most cases Odroid C2 is used with a eMMC card. So far the eMMC slot was assigned dev number 1 (0 is the SD slot). So on uboot prompt we had to manually switch the mmc device first. Therefore change the device number assignment. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- arch/arm/dts/meson-gxbb-odroidc2.dts | 2 ++ 1 file changed, 2 insertions(+)