| Message ID | 20081104111118.GQ3162@earth.li |
|---|---|
| State | Accepted, archived |
| Delegated to: | Jeff Garzik |
| Headers | show |
Jonathan McDowell wrote: > Currently the hso driver registers a WLAN rfkill switch, which is > intended for 802.11 wireless network devices. Given that this driver > supports GSM/HSPA devices it's more appropriate to register a WWAN > rfkill switch type. Cool!!! We both sent the same patch almost at the same time :) > Signed-Off-By: Jonathan McDowell <noodles@earth.li> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 1164c52..3f49e83 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -2188,7 +2188,7 @@ static void hso_create_rfkill(struct hso_device *hso_dev, char *rfkn; hso_net->rfkill = rfkill_allocate(&interface_to_usbdev(interface)->dev, - RFKILL_TYPE_WLAN); + RFKILL_TYPE_WWAN); if (!hso_net->rfkill) { dev_err(dev, "%s - Out of memory\n", __func__); return;
Currently the hso driver registers a WLAN rfkill switch, which is intended for 802.11 wireless network devices. Given that this driver supports GSM/HSPA devices it's more appropriate to register a WWAN rfkill switch type. Signed-Off-By: Jonathan McDowell <noodles@earth.li> ----- ----- J.