diff mbox

[ovs-dev,2/3] dpif-netlink: Handle netlink errors on port del.

Message ID 20170412201948.30978-2-joe@ovn.org
State Accepted
Headers show

Commit Message

Joe Stringer April 12, 2017, 8:19 p.m. UTC 
From: Eric Garver <e@erig.me>

The return code of dpif_netlink_port_query__() was not being checked.

Fixes: da467899ab6e ("Windows: Add internal switch port per OVS bridge")
Signed-off-by: Eric Garver <e@erig.me>
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Signed-off-by: Joe Stringer <joe@ovn.org>
---
 lib/dpif-netlink.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Joe Stringer April 12, 2017, 8:59 p.m. UTC | #1 
On 12 April 2017 at 13:19, Joe Stringer <joe@ovn.org> wrote:
> From: Eric Garver <e@erig.me>
>
> The return code of dpif_netlink_port_query__() was not being checked.
>
> Fixes: da467899ab6e ("Windows: Add internal switch port per OVS bridge")
> Signed-off-by: Eric Garver <e@erig.me>
> Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
> Signed-off-by: Joe Stringer <joe@ovn.org>

Applied to master and branch-2.7.
diff mbox

Patch

diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index e0acf5cce3cf..e27524754a05 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -956,7 +956,11 @@  dpif_netlink_port_del__(struct dpif_netlink *dpif, odp_port_t port_no)
     vport.port_no = port_no;
 #ifdef _WIN32
     struct dpif_port temp_dpif_port;
-    dpif_netlink_port_query__(dpif, port_no, NULL, &temp_dpif_port);
+
+    error = dpif_netlink_port_query__(dpif, port_no, NULL, &temp_dpif_port);
+    if (error) {
+        return error;
+    }
     if (!strcmp(temp_dpif_port.type, "internal")) {
         if (!delete_wmi_port(temp_dpif_port.name)){
             VLOG_ERR("Could not delete wmi port with name: %s",