diff mbox

[net-next] bpf: add test_progs to .gitignore

Message ID 20170411121427.GB5207@gmail.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Alexander Alemayhu April 11, 2017, 12:14 p.m. UTC 
On Tue, Apr 11, 2017 at 01:49:10PM +0200, Daniel Borkmann wrote:
> 
> Good point, we should also add '*.o' in that case for the
> TEST_GEN_FILES specified objs that clang generates.

Think that is covered by other files but added. Would it be
okay to ignore all the generated files, like the below?

commit 1036c0af4dc381c2571947f197c9d30c2c9f4510
Author: Alexander Alemayhu <alexander@alemayhu.com>
Date:   Tue Apr 11 13:31:32 2017 +0200

    bpf: ignore generated files
    
    o add test_progs to tools/testing/selftests/bpf/.gitignore and the other
    generated files.
    o new ignore file in samples/bpf
    
    Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com>


Thanks.

Comments

David Ahern April 11, 2017, 2:08 p.m. UTC | #1 
On 4/11/17 6:14 AM, Alexander Alemayhu wrote:
> On Tue, Apr 11, 2017 at 01:49:10PM +0200, Daniel Borkmann wrote:
>>
>> Good point, we should also add '*.o' in that case for the
>> TEST_GEN_FILES specified objs that clang generates.
> 
> Think that is covered by other files but added. Would it be
> okay to ignore all the generated files, like the below?

listing each program is not a sustainable way to do this. It would be
simpler to put build targets into a build directory and then ignore the
build directory.
Alexander Alemayhu April 11, 2017, 2:43 p.m. UTC | #2 
On Tue, Apr 11, 2017 at 08:08:24AM -0600, David Ahern wrote:
> 
> listing each program is not a sustainable way to do this. It would be
> simpler to put build targets into a build directory and then ignore the
> build directory.

Agreed. It has probably been raised before, but if no one else does I can send
something later (still learning the make syntax).

Thanks.
David Ahern April 11, 2017, 3:16 p.m. UTC | #3 
On 4/11/17 8:43 AM, Alexander Alemayhu wrote:
> On Tue, Apr 11, 2017 at 08:08:24AM -0600, David Ahern wrote:
>> listing each program is not a sustainable way to do this. It would be
>> simpler to put build targets into a build directory and then ignore the
>> build directory.
> Agreed. It has probably been raised before, but if no one else does I can send
> something later (still learning the make syntax).

Getting samples/bpf to honor the O= setting is needed as well.
diff mbox

Patch

diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
new file mode 100644
index 000000000000..6537659507f1
--- /dev/null
+++ b/samples/bpf/.gitignore
@@ -0,0 +1,35 @@ 
+fds_example
+lathist
+lwt_len_hist
+map_perf_test
+offwaketime
+per_socket_stats_example
+sampleip
+sock_example
+sockex1
+sockex2
+sockex3
+spintest
+tc_l2_redirect
+test_cgrp2_array_pin
+test_cgrp2_attach
+test_cgrp2_attach2
+test_cgrp2_sock
+test_cgrp2_sock2
+test_current_task_under_cgroup
+test_lru_dist
+test_map_in_map
+test_overhead
+test_probe_write_user
+trace_event
+trace_output
+tracex1
+tracex2
+tracex3
+tracex4
+tracex5
+tracex6
+xdp1
+xdp2
+xdp_tx_iptunnel
+*.o
diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
index 541d9d7fad5a..78c8fb7077e0 100644
--- a/tools/testing/selftests/bpf/.gitignore
+++ b/tools/testing/selftests/bpf/.gitignore
@@ -3,3 +3,8 @@  test_maps
 test_lru_map
 test_lpm_map
 test_tag
+test_progs
+FEATURE-DUMP.libbpf
+feature/
+fixdep
+*.o