| Message ID | 20170403091444.29876-5-clabbe.montjoie@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Mon, Apr 03, 2017 at 11:14:28AM +0200, Corentin Labbe wrote: > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > .../devicetree/bindings/misc/allwinner,syscon.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/allwinner,syscon.txt > > diff --git a/Documentation/devicetree/bindings/misc/allwinner,syscon.txt b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt > new file mode 100644 > index 0000000..9f5f1f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt > @@ -0,0 +1,19 @@ > +* Allwinner sun8i system controller > + > +This file describes the bindings for the system controller present in > +Allwinner SoC H3, A83T and A64. > +The principal function of this syscon is to control EMAC PHY choice and > +config. > + > +Required properties for the system controller: > +- reg: address and length of the register for the device. > +- compatible: should be "syscon" and one of the following string: > + "allwinner,sun8i-h3-system-controller" > + "allwinner,sun8i-a64-system-controller" > + "allwinner,sun8i-a83t-system-controller" > + > +Example: > +syscon: syscon@01c00000 { > + compatible = "syscon", "allwinner,sun8i-h3-system-controller"; The syntax is the more specific first, so your compatibles should be the other way around. Maxime
On Mon, Apr 03, 2017 at 01:19:54PM +0200, Maxime Ripard wrote: > On Mon, Apr 03, 2017 at 11:14:28AM +0200, Corentin Labbe wrote: > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > --- > > .../devicetree/bindings/misc/allwinner,syscon.txt | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/misc/allwinner,syscon.txt > > > > diff --git a/Documentation/devicetree/bindings/misc/allwinner,syscon.txt b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt > > new file mode 100644 > > index 0000000..9f5f1f5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt > > @@ -0,0 +1,19 @@ > > +* Allwinner sun8i system controller > > + > > +This file describes the bindings for the system controller present in > > +Allwinner SoC H3, A83T and A64. > > +The principal function of this syscon is to control EMAC PHY choice and > > +config. > > + > > +Required properties for the system controller: > > +- reg: address and length of the register for the device. > > +- compatible: should be "syscon" and one of the following string: > > + "allwinner,sun8i-h3-system-controller" > > + "allwinner,sun8i-a64-system-controller" > > + "allwinner,sun8i-a83t-system-controller" > > + > > +Example: > > +syscon: syscon@01c00000 { > > + compatible = "syscon", "allwinner,sun8i-h3-system-controller"; > > The syntax is the more specific first, so your compatibles should be > the other way around. > Changed it everywhere, and forgot to do it here I will change it Thanks Regards -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/misc/allwinner,syscon.txt b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt new file mode 100644 index 0000000..9f5f1f5 --- /dev/null +++ b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt @@ -0,0 +1,19 @@ +* Allwinner sun8i system controller + +This file describes the bindings for the system controller present in +Allwinner SoC H3, A83T and A64. +The principal function of this syscon is to control EMAC PHY choice and +config. + +Required properties for the system controller: +- reg: address and length of the register for the device. +- compatible: should be "syscon" and one of the following string: + "allwinner,sun8i-h3-system-controller" + "allwinner,sun8i-a64-system-controller" + "allwinner,sun8i-a83t-system-controller" + +Example: +syscon: syscon@01c00000 { + compatible = "syscon", "allwinner,sun8i-h3-system-controller"; + reg = <0x01c00000 0x1000>; +};
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- .../devicetree/bindings/misc/allwinner,syscon.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/allwinner,syscon.txt