| Message ID | 1286727021.2435.17.camel@localhost |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Andy Walls <awalls@md.metrocast.net> Date: Sun, 10 Oct 2010 12:10:21 -0400 > In making an IPv4 routing decision, packets with an all 1's broadcast > destination are accepted as input packets, before being checked for being a > martian. Remove the martian check for the all 1's broadcast destination > address. Make the initial check for the all 1's broadcast destination > address easier to read. > > Signed-off-by: Andy Walls <awalls@md.metrocast.net> Your email client corrupted this patch, by turning tab characters into spaces, amongst other things. Please give Documentation/email-clients.txt a read and resubmit this patch after you have these issues sorted out. Thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2010-10-12 at 12:28 -0700, David Miller wrote: > From: Andy Walls <awalls@md.metrocast.net> > Date: Sun, 10 Oct 2010 12:10:21 -0400 > > > In making an IPv4 routing decision, packets with an all 1's broadcast > > destination are accepted as input packets, before being checked for being a > > martian. Remove the martian check for the all 1's broadcast destination > > address. Make the initial check for the all 1's broadcast destination > > address easier to read. > > > > Signed-off-by: Andy Walls <awalls@md.metrocast.net> > > Your email client corrupted this patch, by turning tab characters > into spaces, amongst other things. No, that was me in a rush, thoughtlessly cutting and pasting into the e-mail client window. I will resubmit shortly. Sorry for the wasting your time on the malformed submission. Regards, Andy > Please give Documentation/email-clients.txt a read and resubmit this > patch after you have these issues sorted out. > > Thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index ac6559c..2b8c071 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2124,7 +2124,7 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 ipv4_is_loopback(saddr)) goto martian_source; - if (daddr == htonl(0xFFFFFFFF) || (saddr == 0 && daddr == 0)) + if (ipv4_is_lbcast(daddr) || (saddr == 0 && daddr == 0)) goto brd_input; /* Accept zero addresses only to limited broadcast; @@ -2133,8 +2133,7 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 if (ipv4_is_zeronet(saddr)) goto martian_source; - if (ipv4_is_lbcast(daddr) || ipv4_is_zeronet(daddr) || - ipv4_is_loopback(daddr)) + if (ipv4_is_zeronet(daddr) || ipv4_is_loopback(daddr)) goto martian_destination; /*
In making an IPv4 routing decision, packets with an all 1's broadcast destination are accepted as input packets, before being checked for being a martian. Remove the martian check for the all 1's broadcast destination address. Make the initial check for the all 1's broadcast destination address easier to read. Signed-off-by: Andy Walls <awalls@md.metrocast.net> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html