diff mbox

[LEDE-DEV,v2] ar71xx: Add TP-LINK TL-WR841N v12 support.

Message ID owrt-patch-20170325-3-v2@vittgam.net
State Accepted
Delegated to: Piotr Dymacz
Headers show

Commit Message

Vittorio Gambaletta March 26, 2017, 7:55 a.m. UTC
This router has the same hardware of TP-LINK TL-WR841N v11 (same
FCC ID, same TFTP image name...).

The stock firmware web interface does not seem to accept the LEDE
factory image, but it can be flashed via the u-boot TFTP recovery
by long-pressing the reset button after power on.

The TFTP image name is wr841nv11_tp_recovery.bin (yes, v11, not v12).

Signed-off-by: Vittorio Gambaletta <openwrt@vittgam.net>

---

Comments

Piotr Dymacz March 27, 2017, 9:22 a.m. UTC | #1
Hello Vittorio,

On 26.03.2017 09:55, Vittorio Gambaletta (VittGam) wrote:
> This router has the same hardware of TP-LINK TL-WR841N v11 (same
> FCC ID, same TFTP image name...).
>
> The stock firmware web interface does not seem to accept the LEDE
> factory image, but it can be flashed via the u-boot TFTP recovery
> by long-pressing the reset button after power on.

So, I have just made a test (using TL-WR841N v9 "converted" to v12 EU) 
and factory-eu image works without any problems (Firefox 52).

I'm going to pick up your patch with small change in commit message and 
subject (please, don't add dot at the end of the subject next time).

--
Best regards,
Piotr Dymacz

>
> The TFTP image name is wr841nv11_tp_recovery.bin (yes, v11, not v12).
>
> Signed-off-by: Vittorio Gambaletta <openwrt@vittgam.net>
>
> ---
>
> diff --git a/target/linux/ar71xx/image/tp-link.mk b/target/linux/ar71xx/image/tp-link.mk
> index cf2e5e7..cea039d 100644
> --- a/target/linux/ar71xx/image/tp-link.mk
> +++ b/target/linux/ar71xx/image/tp-link.mk
> @@ -736,6 +736,12 @@ define Device/tl-wr841-v11
>    IMAGE/factory-eu.bin := append-rootfs | mktplinkfw factory -C EU
>  endef
>
> +define Device/tl-wr841-v12
> +  $(Device/tl-wr841-v11)
> +  DEVICE_TITLE := TP-LINK TL-WR841N/ND v12
> +  TPLINK_HWID := 0x08410012
> +endef
> +
>  define Device/tl-wr842n-v1
>    $(Device/tplink-8m)
>    DEVICE_TITLE := TP-LINK TL-WR842N/ND v1
> @@ -778,7 +784,7 @@ define Device/tl-wr847n-v8
>    DEVICE_PROFILE := TLWR841
>    TPLINK_HWID := 0x08470008
>  endef
> -TARGET_DEVICES += tl-wr840n-v2 tl-wr840n-v3 tl-wr841-v1.5 tl-wr841-v3 tl-wr841-v5 tl-wr841-v7 tl-wr841-v8 tl-wr841-v9 tl-wr841-v10 tl-wr841-v11 tl-wr842n-v1 tl-wr842n-v2 tl-wr842n-v3 tl-wr843nd-v1 tl-wr847n-v8
> +TARGET_DEVICES += tl-wr840n-v2 tl-wr840n-v3 tl-wr841-v1.5 tl-wr841-v3 tl-wr841-v5 tl-wr841-v7 tl-wr841-v8 tl-wr841-v9 tl-wr841-v10 tl-wr841-v11 tl-wr841-v12 tl-wr842n-v1 tl-wr842n-v2 tl-wr842n-v3 tl-wr843nd-v1 tl-wr847n-v8
>
>  define Device/tl-wr941nd-v2
>    $(Device/tplink-4m)
>
Vittorio Gambaletta March 30, 2017, 4:21 a.m. UTC | #2
Hello Piotr,

On 27/03/2017 11:22:05 CEST, Piotr Dymacz wrote:
> Hello Vittorio,
> 
> On 26.03.2017 09:55, Vittorio Gambaletta (VittGam) wrote:
>> This router has the same hardware of TP-LINK TL-WR841N v11 (same
>> FCC ID, same TFTP image name...).
>>
>> The stock firmware web interface does not seem to accept the LEDE
>> factory image, but it can be flashed via the u-boot TFTP recovery
>> by long-pressing the reset button after power on.
> 
> So, I have just made a test (using TL-WR841N v9 "converted" to v12 EU) 
> and factory-eu image works without any problems (Firefox 52).

Ok, perfect, then!

> I'm going to pick up your patch with small change in commit message and 
> subject (please, don't add dot at the end of the subject next time).

Thanks for your suggestion. I knew the exact contrary and in fact I'm
adding dot at end of subject every time... Do you know if there is some
place (that I might have very well missed if it exists...) where this
kind of style rules are written?

Cheers,
Vittorio
Alberto Bursi March 30, 2017, 6:16 a.m. UTC | #3
On 03/30/2017 06:21 AM, Vittorio G (VittGam) wrote:
>
> Thanks for your suggestion. I knew the exact contrary and in fact I'm
> adding dot at end of subject every time... Do you know if there is some
> place (that I might have very well missed if it exists...) where this
> kind of style rules are written?
>
>

See this page in the site/wiki https://lede-project.org/submitting-patches

-Alberto
diff mbox

Patch

diff --git a/target/linux/ar71xx/image/tp-link.mk b/target/linux/ar71xx/image/tp-link.mk
index cf2e5e7..cea039d 100644
--- a/target/linux/ar71xx/image/tp-link.mk
+++ b/target/linux/ar71xx/image/tp-link.mk
@@ -736,6 +736,12 @@  define Device/tl-wr841-v11
   IMAGE/factory-eu.bin := append-rootfs | mktplinkfw factory -C EU
 endef
 
+define Device/tl-wr841-v12
+  $(Device/tl-wr841-v11)
+  DEVICE_TITLE := TP-LINK TL-WR841N/ND v12
+  TPLINK_HWID := 0x08410012
+endef
+
 define Device/tl-wr842n-v1
   $(Device/tplink-8m)
   DEVICE_TITLE := TP-LINK TL-WR842N/ND v1
@@ -778,7 +784,7 @@  define Device/tl-wr847n-v8
   DEVICE_PROFILE := TLWR841
   TPLINK_HWID := 0x08470008
 endef
-TARGET_DEVICES += tl-wr840n-v2 tl-wr840n-v3 tl-wr841-v1.5 tl-wr841-v3 tl-wr841-v5 tl-wr841-v7 tl-wr841-v8 tl-wr841-v9 tl-wr841-v10 tl-wr841-v11 tl-wr842n-v1 tl-wr842n-v2 tl-wr842n-v3 tl-wr843nd-v1 tl-wr847n-v8
+TARGET_DEVICES += tl-wr840n-v2 tl-wr840n-v3 tl-wr841-v1.5 tl-wr841-v3 tl-wr841-v5 tl-wr841-v7 tl-wr841-v8 tl-wr841-v9 tl-wr841-v10 tl-wr841-v11 tl-wr841-v12 tl-wr842n-v1 tl-wr842n-v2 tl-wr842n-v3 tl-wr843nd-v1 tl-wr847n-v8
 
 define Device/tl-wr941nd-v2
   $(Device/tplink-4m)