Message ID | 20170321204828.31303-1-raltherr@google.com |
---|---|
State | Awaiting Upstream, archived |
Headers | show |
> Signed-off-by: Rick Altherr <raltherr@google.com> extreme nitpicking below --- > > Changes in v2: > - Rewritten as an IIO ADC device > > .../devicetree/bindings/iio/adc/aspeed_adc.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > new file mode 100644 > index 000000000000..7748c2c2ad0c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > @@ -0,0 +1,20 @@ > +Aspeed AST2400/2500 ADC > + > +This device is a 10-bit converter for 16 voltage channels. All inputs are > +single ended. > + > +Required properties: > +- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc" > +- reg: memory window mapping address and length > +- clocks: Input clock used to derive the sample clock. Expected to be the > + SoC's APB clock. > +- #io-channel-cells: Must be set to <1> to indicate channels are selected > + by index. > + > +Example: > + adc@1e6e9000 { > + compatible = "aspeed,ast2400-adc"; > + reg = <0x1e6e9000 0xB0>; maybe 0xb0 (consistent lowercase hex)? > + clocks = <&clk_apb>; > + #io-channel-cells = <1>; > + }; >
On Tue, Mar 21, 2017 at 01:48:27PM -0700, Rick Altherr wrote: > Signed-off-by: Rick Altherr <raltherr@google.com> > --- > > Changes in v2: > - Rewritten as an IIO ADC device > > .../devicetree/bindings/iio/adc/aspeed_adc.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt new file mode 100644 index 000000000000..7748c2c2ad0c --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt @@ -0,0 +1,20 @@ +Aspeed AST2400/2500 ADC + +This device is a 10-bit converter for 16 voltage channels. All inputs are +single ended. + +Required properties: +- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc" +- reg: memory window mapping address and length +- clocks: Input clock used to derive the sample clock. Expected to be the + SoC's APB clock. +- #io-channel-cells: Must be set to <1> to indicate channels are selected + by index. + +Example: + adc@1e6e9000 { + compatible = "aspeed,ast2400-adc"; + reg = <0x1e6e9000 0xB0>; + clocks = <&clk_apb>; + #io-channel-cells = <1>; + };
Signed-off-by: Rick Altherr <raltherr@google.com> --- Changes in v2: - Rewritten as an IIO ADC device .../devicetree/bindings/iio/adc/aspeed_adc.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt