Message ID | 1286546523-3340-2-git-send-email-remi@remlab.net |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Rémi Denis-Courmont <remi@remlab.net> Date: Fri, 8 Oct 2010 17:02:01 +0300 > From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> > > As it currently is, the new code path is not compatible with existing > Nokia modems. This would break existing userspace for Nokia modem, such > as the existing oFono ISI driver. > > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> This really needs to be designed such that it can co-exist with current userland technology. Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Le samedi 9 octobre 2010 00:17:30 David Miller, vous avez écrit : > From: Rémi Denis-Courmont <remi@remlab.net> > Date: Fri, 8 Oct 2010 17:02:01 +0300 > > > From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> > > > > As it currently is, the new code path is not compatible with existing > > Nokia modems. This would break existing userspace for Nokia modem, such > > as the existing oFono ISI driver. > > > > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> > > This really needs to be designed such that it can co-exist with current > userland technology. Yeah, don't tell me. This kinda static option works for Linux kernel on an embedded device like my employer. But it does not fly on the desktop. This big patch came as a surprise, so did its merging. I don't when it can be improved.
Hi, On Fri, Oct 08, 2010 at 16:02:01 +0200, Rémi Denis-Courmont wrote: > From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> > > As it currently is, the new code path is not compatible with existing > Nokia modems. This would break existing userspace for Nokia modem, such > as the existing oFono ISI driver. > > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Yes, the pipe controller logic is not intended for existing Nokia modems that already implement pipe controller inside them. Thank you for putting correct warning message. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/phonet/Kconfig b/net/phonet/Kconfig index 901956a..a4fceb8 100644 --- a/net/phonet/Kconfig +++ b/net/phonet/Kconfig @@ -24,4 +24,5 @@ config PHONET_PIPECTRLR data with Nokia Slim modems like WG2.5 used on ST-Ericsson U8500 platform. - If unsure, say N. + This option is incompatible with older Nokia modems. + Say N here unless you really know what you are doing.