Message ID | eac57b26e76a472ec1799b1ebd41580396dbec73.1488215509.git-series.maxime.ripard@free-electrons.com |
---|---|
State | Accepted |
Commit | 8cab65bf9af698694235718f1cf68b1f59df6cd2 |
Delegated to: | Jagannadha Sutradharudu Teki |
Headers | show |
On Mon, Feb 27, 2017 at 06:22:15PM +0100, Maxime Ripard wrote: > The CHIP Pro is a SoM that features the GR8 SIP, an AXP209, a BT/WiFi chip > and a 512MiB SLC NAND. > > This it's an SLC NAND, it doesn't suffer the same drawbacks than found on > the MLC NANDs, and we can enable it right away. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > --- > configs/CHIP_pro_defconfig | 33 +++++++++++++++++++++++++++++++++ [snip] > +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,SYS_NAND_BLOCK_SIZE=0x40000,SYS_NAND_PAGE_SIZE=4096,SYS_NAND_OOBSIZE=256" Conversion itself won't be fun (I can see it'll take some regex'ing before hand to convert various values to a number) but can you please add Kconfig entires for SYS_NAND_xxx values and populate those for this baord instead of adding more SYS_EXTRA_OPTIONS? Thanks!
Hi Tom, On Wed, Mar 01, 2017 at 10:58:56AM -0500, Tom Rini wrote: > On Mon, Feb 27, 2017 at 06:22:15PM +0100, Maxime Ripard wrote: > > > The CHIP Pro is a SoM that features the GR8 SIP, an AXP209, a BT/WiFi chip > > and a 512MiB SLC NAND. > > > > This it's an SLC NAND, it doesn't suffer the same drawbacks than found on > > the MLC NANDs, and we can enable it right away. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > --- > > configs/CHIP_pro_defconfig | 33 +++++++++++++++++++++++++++++++++ > [snip] > > +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,SYS_NAND_BLOCK_SIZE=0x40000,SYS_NAND_PAGE_SIZE=4096,SYS_NAND_OOBSIZE=256" > > Conversion itself won't be fun (I can see it'll take some regex'ing > before hand to convert various values to a number) but can you please > add Kconfig entires for SYS_NAND_xxx values and populate those for this > baord instead of adding more SYS_EXTRA_OPTIONS? Thanks! If you mean converting only the Allwinner boards to it, then yes, sure. If you also mean converting all the other architectures, then I'm sorry but I don't have the time to do that. Maxime
On Fri, Mar 03, 2017 at 03:48:08PM +0100, Maxime Ripard wrote: > Hi Tom, > > On Wed, Mar 01, 2017 at 10:58:56AM -0500, Tom Rini wrote: > > On Mon, Feb 27, 2017 at 06:22:15PM +0100, Maxime Ripard wrote: > > > > > The CHIP Pro is a SoM that features the GR8 SIP, an AXP209, a BT/WiFi chip > > > and a 512MiB SLC NAND. > > > > > > This it's an SLC NAND, it doesn't suffer the same drawbacks than found on > > > the MLC NANDs, and we can enable it right away. > > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > > --- > > > configs/CHIP_pro_defconfig | 33 +++++++++++++++++++++++++++++++++ > > [snip] > > > +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,SYS_NAND_BLOCK_SIZE=0x40000,SYS_NAND_PAGE_SIZE=4096,SYS_NAND_OOBSIZE=256" > > > > Conversion itself won't be fun (I can see it'll take some regex'ing > > before hand to convert various values to a number) but can you please > > add Kconfig entires for SYS_NAND_xxx values and populate those for this > > baord instead of adding more SYS_EXTRA_OPTIONS? Thanks! > > If you mean converting only the Allwinner boards to it, then yes, > sure. If you also mean converting all the other architectures, then > I'm sorry but I don't have the time to do that. Yeah, if you add the Kconfig entries and make use of them here (and convert the rest of sunxi, which I guess is just CHIP) that's fine. These are non-trivial enough that moveconfig.py won't get them right I suspect. Thanks!
diff --git a/configs/CHIP_pro_defconfig b/configs/CHIP_pro_defconfig new file mode 100644 index 000000000000..df43e5a12d06 --- /dev/null +++ b/configs/CHIP_pro_defconfig @@ -0,0 +1,33 @@ +CONFIG_ARM=y +CONFIG_ARCH_SUNXI=y +CONFIG_SPL_I2C_SUPPORT=y +# CONFIG_SPL_MMC_SUPPORT is not set +CONFIG_SPL_NAND_SUPPORT=y +CONFIG_MACH_SUN5I=y +CONFIG_DRAM_TIMINGS_DDR3_800E_1066G_1333J=y +CONFIG_USB0_VBUS_PIN="PB10" +CONFIG_DEFAULT_DEVICE_TREE="sun5i-gr8-chip-pro" +CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,SYS_NAND_BLOCK_SIZE=0x40000,SYS_NAND_PAGE_SIZE=4096,SYS_NAND_OOBSIZE=256" +CONFIG_ENV_IS_IN_UBI=y +CONFIG_ENV_UBI_PART="UBI" +CONFIG_ENV_UBI_VOLUME="uboot-env" +CONFIG_SPL=y +# CONFIG_CMD_IMLS is not set +# CONFIG_CMD_LOADB is not set +# CONFIG_CMD_LOADS is not set +# CONFIG_CMD_FLASH is not set +# CONFIG_CMD_FPGA is not set +CONFIG_CMD_MTDPARTS=y +CONFIG_MTDIDS_DEFAULT="nand0=sunxi-nand.0" +CONFIG_MTDPARTS_DEFAULT="mtdparts=sunxi-nand.0:256k(spl),256k(spl-backup),2m(uboot),2m(uboot-backup),-(UBI)" +# CONFIG_MMC is not set +CONFIG_NAND_SUNXI=y +CONFIG_AXP_ALDO3_VOLT=3300 +CONFIG_AXP_ALDO4_VOLT=3300 +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_MUSB_GADGET=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_DOWNLOAD=y +CONFIG_G_DNL_MANUFACTURER="Allwinner Technology" +CONFIG_G_DNL_VENDOR_NUM=0x1f3a +CONFIG_G_DNL_PRODUCT_NUM=0x1010