| Message ID | 20170217200412.11680-1-david.daney@cavium.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 02/17/2017 12:04 PM, David Daney wrote: > Some Cavium dev boards have firmware which doesn't supply a proper > ethernet-phy-ieee802.3-c22" compatible property. Restore these boards > to working order by whitelisting this compatible value. > > Signed-off-by: David Daney <david.daney@cavium.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/of/of_mdio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c > index 262281b..0b29798 100644 > --- a/drivers/of/of_mdio.c > +++ b/drivers/of/of_mdio.c > @@ -147,6 +147,7 @@ EXPORT_SYMBOL(of_mdio_parse_addr); > */ > static const struct of_device_id whitelist_phys[] = { > { .compatible = "brcm,40nm-ephy" }, > + { .compatible = "broadcom,bcm5241" }, And that's not the vendor prefix from vendor-prefixes.txt. > { .compatible = "marvell,88E1111", }, > { .compatible = "marvell,88e1116", }, > { .compatible = "marvell,88e1118", }, >
On 02/17/2017 12:09 PM, Florian Fainelli wrote: > On 02/17/2017 12:04 PM, David Daney wrote: >> Some Cavium dev boards have firmware which doesn't supply a proper >> ethernet-phy-ieee802.3-c22" compatible property. Restore these boards >> to working order by whitelisting this compatible value. >> >> Signed-off-by: David Daney <david.daney@cavium.com> > > Acked-by: Florian Fainelli <f.fainelli@gmail.com> > >> --- >> drivers/of/of_mdio.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c >> index 262281b..0b29798 100644 >> --- a/drivers/of/of_mdio.c >> +++ b/drivers/of/of_mdio.c >> @@ -147,6 +147,7 @@ EXPORT_SYMBOL(of_mdio_parse_addr); >> */ >> static const struct of_device_id whitelist_phys[] = { >> { .compatible = "brcm,40nm-ephy" }, >> + { .compatible = "broadcom,bcm5241" }, > > And that's not the vendor prefix from vendor-prefixes.txt. No, that dts containing this value predates vendor-prefixes.txt. Previous to commit 801a8ef54e8b ("of: phy: Only register a phy device for phys"), the form of the compatible string didn't matter for phys > > >> { .compatible = "marvell,88E1111", }, >> { .compatible = "marvell,88e1116", }, >> { .compatible = "marvell,88e1118", }, >> > >
From: David Daney <david.daney@cavium.com> Date: Fri, 17 Feb 2017 12:04:12 -0800 > Some Cavium dev boards have firmware which doesn't supply a proper > ethernet-phy-ieee802.3-c22" compatible property. Restore these boards > to working order by whitelisting this compatible value. > > Signed-off-by: David Daney <david.daney@cavium.com> Applied.
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index 262281b..0b29798 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -147,6 +147,7 @@ EXPORT_SYMBOL(of_mdio_parse_addr); */ static const struct of_device_id whitelist_phys[] = { { .compatible = "brcm,40nm-ephy" }, + { .compatible = "broadcom,bcm5241" }, { .compatible = "marvell,88E1111", }, { .compatible = "marvell,88e1116", }, { .compatible = "marvell,88e1118", },
Some Cavium dev boards have firmware which doesn't supply a proper ethernet-phy-ieee802.3-c22" compatible property. Restore these boards to working order by whitelisting this compatible value. Signed-off-by: David Daney <david.daney@cavium.com> --- drivers/of/of_mdio.c | 1 + 1 file changed, 1 insertion(+)