diff mbox

[1/2] package/qt5: remove menu comment about depreceted modules

Message ID 1486517040-8075-2-git-send-email-mr.zoltan.gyarmati@gmail.com
State Superseded
Headers show

Commit Message

Zoltan Gyarmati Feb. 8, 2017, 1:23 a.m. UTC
As now the Qt version is configurable to simplify the menu display
logic we remove the menu comment about deprecated modules and
indicate it in the relevant modules' help text instead

Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
---
 package/qt5/Config.in            | 7 +++----
 package/qt5/qt5enginio/Config.in | 3 +++
 2 files changed, 6 insertions(+), 4 deletions(-)

Comments

Thomas Petazzoni Feb. 8, 2017, 8:56 a.m. UTC | #1
Hello,

In the title: depreceted -> deprecated

On Wed,  8 Feb 2017 02:23:59 +0100, Zoltan Gyarmati wrote:

> diff --git a/package/qt5/qt5enginio/Config.in b/package/qt5/qt5enginio/Config.in
> index fcb866c..dba75e2 100644
> --- a/package/qt5/qt5enginio/Config.in
> +++ b/package/qt5/qt5enginio/Config.in
> @@ -10,4 +10,7 @@ config BR2_PACKAGE_QT5ENGINIO
>  
>  	  This package corresponds to the qt5enginio module.
>  
> +	  This package has been tagged as deprecated since version
> +	  5.6 and not recommended for new design.
> +
>  	  http://qt.io

That was not the only change done in the patch series that bumped to
5.8. What was done was:

 1. qt5enginio: move into legacy compatibility
 2. qt53d/qt5quickcontrols2/qt5serialbus: move out of tech preview

So your patch takes care of (1), but not (2). I.e for the qt53d,
qt5quickcontrols2 and qt5serialbus, there should be a note that says:
"This module was in tech preview in Qt 5.6, and promoted to a core
module in Qt ...".

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/qt5/Config.in b/package/qt5/Config.in
index 6929434..3b2c724 100644
--- a/package/qt5/Config.in
+++ b/package/qt5/Config.in
@@ -57,23 +57,22 @@  source "package/qt5/qt5base/Config.in"
 source "package/qt5/qt5canvas3d/Config.in"
 source "package/qt5/qt5connectivity/Config.in"
 source "package/qt5/qt5declarative/Config.in"
+source "package/qt5/qt5enginio/Config.in"
 source "package/qt5/qt5graphicaleffects/Config.in"
 source "package/qt5/qt5imageformats/Config.in"
 source "package/qt5/qt5location/Config.in"
 source "package/qt5/qt5multimedia/Config.in"
 source "package/qt5/qt5quickcontrols/Config.in"
 source "package/qt5/qt5quickcontrols2/Config.in"
+source "package/qt5/qt5script/Config.in"
 source "package/qt5/qt5sensors/Config.in"
 source "package/qt5/qt5serialbus/Config.in"
 source "package/qt5/qt5serialport/Config.in"
 source "package/qt5/qt5svg/Config.in"
 source "package/qt5/qt5tools/Config.in"
 source "package/qt5/qt5webchannel/Config.in"
+source "package/qt5/qt5webkit/Config.in"
 source "package/qt5/qt5websockets/Config.in"
 source "package/qt5/qt5x11extras/Config.in"
 source "package/qt5/qt5xmlpatterns/Config.in"
-comment "legacy compatibility"
-source "package/qt5/qt5enginio/Config.in"
-source "package/qt5/qt5script/Config.in"
-source "package/qt5/qt5webkit/Config.in"
 endif
diff --git a/package/qt5/qt5enginio/Config.in b/package/qt5/qt5enginio/Config.in
index fcb866c..dba75e2 100644
--- a/package/qt5/qt5enginio/Config.in
+++ b/package/qt5/qt5enginio/Config.in
@@ -10,4 +10,7 @@  config BR2_PACKAGE_QT5ENGINIO
 
 	  This package corresponds to the qt5enginio module.
 
+	  This package has been tagged as deprecated since version
+	  5.6 and not recommended for new design.
+
 	  http://qt.io