diff mbox

[avr] : For PR78883 #3

Message ID 6e9eb31e-7d95-ca82-6615-0056e5e2f9fe@gjlay.de
State New
Headers show

Commit Message

Georg-Johann Lay Jan. 13, 2017, 11:53 a.m. UTC 
This is 3rd way to fix PR78883 by rejecting malicious expressions
from the start.

Ok for trunk?

Johann

gcc/
	PR target/78883
	* config/avr/avr.c (rtl-iter.h): Include it.
	(TARGET_LEGITIMATE_COMBINED_INSN): New hook define...
	(avr_legitimate_combined_insn): ...and implementation.

gcc/testsuite/
	PR target/78883
	* gcc.c-torture/compile/pr78883.c: New test.

Comments

Georg-Johann Lay Feb. 6, 2017, 10:06 a.m. UTC | #1 
https://gcc.gnu.org/ml/gcc-patches/2017-01/msg00926.html

On 13.01.2017 12:53, Georg-Johann Lay wrote:
> This is 3rd way to fix PR78883 by rejecting malicious expressions
> from the start.
>
> Ok for trunk?
>
> Johann
>
> gcc/
>     PR target/78883
>     * config/avr/avr.c (rtl-iter.h): Include it.
>     (TARGET_LEGITIMATE_COMBINED_INSN): New hook define...
>     (avr_legitimate_combined_insn): ...and implementation.
>
> gcc/testsuite/
>     PR target/78883
>     * gcc.c-torture/compile/pr78883.c: New test.
>
Denis Chertykov Feb. 6, 2017, 10:44 a.m. UTC | #2 
2017-02-06 14:06 GMT+04:00 Georg-Johann Lay <avr@gjlay.de>:
> https://gcc.gnu.org/ml/gcc-patches/2017-01/msg00926.html
>
> On 13.01.2017 12:53, Georg-Johann Lay wrote:
>>
>> This is 3rd way to fix PR78883 by rejecting malicious expressions
>> from the start.
>>
>> Ok for trunk?
>>
>> Johann
>>
>> gcc/
>>     PR target/78883
>>     * config/avr/avr.c (rtl-iter.h): Include it.
>>     (TARGET_LEGITIMATE_COMBINED_INSN): New hook define...
>>     (avr_legitimate_combined_insn): ...and implementation.
>>
>> gcc/testsuite/
>>     PR target/78883
>>     * gcc.c-torture/compile/pr78883.c: New test.
>>
>

Approved.
diff mbox

Patch

Index: config/avr/avr.c
===================================================================
--- config/avr/avr.c	(revision 244001)
+++ config/avr/avr.c	(working copy)
@@ -49,6 +49,7 @@ 
 #include "context.h"
 #include "tree-pass.h"
 #include "print-rtl.h"
+#include "rtl-iter.h"
 
 /* This file should be included last.  */
 #include "target-def.h"
@@ -12823,6 +12824,34 @@  avr_convert_to_type (tree type, tree exp
 }
 
 
+/* Implement `TARGET_LEGITIMATE_COMBINED_INSN'.  */
+
+/* PR78883: Filter out paradoxical SUBREGs of MEM which are not handled
+   properly by following passes.  As INSN_SCHEDULING is off and hence
+   general_operand accepts such expressions, ditch them now.  */
+
+static bool
+avr_legitimate_combined_insn (rtx_insn *insn)
+{
+  subrtx_iterator::array_type array;
+
+  FOR_EACH_SUBRTX (iter, array, PATTERN (insn), NONCONST)
+    {
+      const_rtx op = *iter;
+
+      if (SUBREG_P (op)
+          && MEM_P (SUBREG_REG (op))
+          && (GET_MODE_SIZE (GET_MODE (op))
+              > GET_MODE_SIZE (GET_MODE (SUBREG_REG (op)))))
+        {
+          return false;
+        }
+    }
+
+  return true;
+}
+
+
 /* PR63633: The middle-end might come up with hard regs as input operands.
 
    RMASK is a bit mask representing a subset of hard registers R0...R31:
@@ -14364,6 +14393,9 @@  avr_fold_builtin (tree fndecl, int n_arg
 #define TARGET_USE_BY_PIECES_INFRASTRUCTURE_P \
   avr_use_by_pieces_infrastructure_p
 
+#undef  TARGET_LEGITIMATE_COMBINED_INSN
+#define TARGET_LEGITIMATE_COMBINED_INSN avr_legitimate_combined_insn
+
 struct gcc_target targetm = TARGET_INITIALIZER;
 
 
Index: testsuite/gcc.c-torture/compile/pr78883.c
===================================================================
--- testsuite/gcc.c-torture/compile/pr78883.c	(nonexistent)
+++ testsuite/gcc.c-torture/compile/pr78883.c	(working copy)
@@ -0,0 +1,12 @@ 
+/* { dg-do compile } */
+
+int foo (int *p)
+{
+  int i;
+  for (i = 0; i < 5; i++)
+    {
+      if (p[i] & 1)
+        return i;
+    }
+  return -1;
+}