| Message ID | 1486046861-31348-12-git-send-email-jagan@openedev.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
On Thu, Feb 02, 2017 at 03:47:41PM +0100, Jagan Teki wrote: > From: Jagan Teki <jagan@amarulasolutions.com> > > Few of the dts files in arm are not maintained by specific > arm maintainer, so add MAINTAINERS file at arch/arm/dts/ and > update it wrt specific maintainer. > > Cc: Tom Rini <trini@konsulko.com> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Michael Trimarchi <michael@amarulasolutions.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> This is easier done by just listing the dts files in board/*/MAINTAINERS I think, thanks!
On Thursday 02 February 2017 09:09 PM, Tom Rini wrote: > On Thu, Feb 02, 2017 at 03:47:41PM +0100, Jagan Teki wrote: > >> From: Jagan Teki <jagan@amarulasolutions.com> >> >> Few of the dts files in arm are not maintained by specific >> arm maintainer, so add MAINTAINERS file at arch/arm/dts/ and >> update it wrt specific maintainer. >> >> Cc: Tom Rini <trini@konsulko.com> >> Cc: Stefano Babic <sbabic@denx.de> >> Cc: Michael Trimarchi <michael@amarulasolutions.com> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > This is easier done by just listing the dts files in board/*/MAINTAINERS > I think, thanks! But the only think I see here is, about soc dtsi file say for example imx6qdl-icore.dtsi, imx6q-icore.dts are specific vendor board(there mentioned in board/*/MAINTAINERS) but imx6qdl.dtsi is specific to i.MX6QDL SOC so these need to be listed here instead of boards since it is common for other vendors too. thanks!
On Thu, Feb 02, 2017 at 09:54:09PM +0100, Jagan Teki wrote: > On Thursday 02 February 2017 09:09 PM, Tom Rini wrote: > >On Thu, Feb 02, 2017 at 03:47:41PM +0100, Jagan Teki wrote: > > > >>From: Jagan Teki <jagan@amarulasolutions.com> > >> > >>Few of the dts files in arm are not maintained by specific > >>arm maintainer, so add MAINTAINERS file at arch/arm/dts/ and > >>update it wrt specific maintainer. > >> > >>Cc: Tom Rini <trini@konsulko.com> > >>Cc: Stefano Babic <sbabic@denx.de> > >>Cc: Michael Trimarchi <michael@amarulasolutions.com> > >>Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > >This is easier done by just listing the dts files in board/*/MAINTAINERS > >I think, thanks! > > But the only think I see here is, about soc dtsi file say for > example imx6qdl-icore.dtsi, imx6q-icore.dts are specific vendor > board(there mentioned in board/*/MAINTAINERS) but imx6qdl.dtsi is > specific to i.MX6QDL SOC so these need to be listed here instead of > boards since it is common for other vendors too. I still don't see it. If it's not in a board MAINTAINERS file it's in the top level one. So Stefano's glob in the top-level one should cover the various core dtsi files.
On Saturday 04 February 2017 05:52 PM, Tom Rini wrote: > On Thu, Feb 02, 2017 at 09:54:09PM +0100, Jagan Teki wrote: >> On Thursday 02 February 2017 09:09 PM, Tom Rini wrote: >>> On Thu, Feb 02, 2017 at 03:47:41PM +0100, Jagan Teki wrote: >>> >>>> From: Jagan Teki <jagan@amarulasolutions.com> >>>> >>>> Few of the dts files in arm are not maintained by specific >>>> arm maintainer, so add MAINTAINERS file at arch/arm/dts/ and >>>> update it wrt specific maintainer. >>>> >>>> Cc: Tom Rini <trini@konsulko.com> >>>> Cc: Stefano Babic <sbabic@denx.de> >>>> Cc: Michael Trimarchi <michael@amarulasolutions.com> >>>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >>> >>> This is easier done by just listing the dts files in board/*/MAINTAINERS >>> I think, thanks! >> >> But the only think I see here is, about soc dtsi file say for >> example imx6qdl-icore.dtsi, imx6q-icore.dts are specific vendor >> board(there mentioned in board/*/MAINTAINERS) but imx6qdl.dtsi is >> specific to i.MX6QDL SOC so these need to be listed here instead of >> boards since it is common for other vendors too. > > I still don't see it. If it's not in a board MAINTAINERS file it's in > the top level one. So Stefano's glob in the top-level one should cover > the various core dtsi files. If ie true we can skip, the only reason for this if he wouldn't that's what I've mentioned on the commit message. thanks!
diff --git a/arch/arm/dts/MAINTAINERS b/arch/arm/dts/MAINTAINERS new file mode 100644 index 0000000..1060553 --- /dev/null +++ b/arch/arm/dts/MAINTAINERS @@ -0,0 +1,9 @@ +i.MX6Q DTS +M: Jagan Teki <jagan@amarulasolutions.com> +S: Maintained +F: arch/arm/dts/imx6q.dtsi + +i.MX6UL DTS +M: Jagan Teki <jagan@amarulasolutions.com> +S: Maintained +F: arch/arm/dts/imx6ul.dtsi diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 83a4e5b..26209ac 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -283,6 +283,7 @@ sub maint_wanted { } File::Find::find(\&maint_wanted, "${lk_path}board"); +File::Find::find(\&maint_wanted, "${lk_path}arch/arm/dts"); foreach my $maint_file (@maint_files) { my $maint;