diff mbox

[U-Boot] regulator: palmas: Fix smps6 - smps9 indices

Message ID 1486111318-5406-1-git-send-email-j-keerthy@ti.com
State Accepted
Commit 3064aa7009aa75299bad66fd6de3916174822bfb
Delegated to: Tom Rini
Headers show

Commit Message

Keerthy Feb. 3, 2017, 8:41 a.m. UTC
Fix smps6 - smps9 indices

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/power/regulator/palmas_regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tero Kristo Feb. 3, 2017, 11:27 a.m. UTC | #1
On 03/02/17 10:41, Keerthy wrote:
> Fix smps6 - smps9 indices

I think this could use a better commit message. What, why?

-Tero

>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/power/regulator/palmas_regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/palmas_regulator.c b/drivers/power/regulator/palmas_regulator.c
> index cce7cd2..399f7a5 100644
> --- a/drivers/power/regulator/palmas_regulator.c
> +++ b/drivers/power/regulator/palmas_regulator.c
> @@ -356,7 +356,7 @@ static int palmas_smps_probe(struct udevice *dev)
>  		case 8:
>  		case 9:
>  		case 10:
> -			idx = dev->driver_data - 4;
> +			idx = dev->driver_data - 3;
>  			uc_pdata->ctrl_reg = palmas_smps_ctrl[type][idx];
>  			uc_pdata->volt_reg = palmas_smps_volt[type][idx];
>  			break;
>
Keerthy Feb. 3, 2017, 11:27 a.m. UTC | #2
On Friday 03 February 2017 04:57 PM, Tero Kristo wrote:
> On 03/02/17 10:41, Keerthy wrote:
>> Fix smps6 - smps9 indices
>
> I think this could use a better commit message. What, why?

Okay Tero.

>
> -Tero
>
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>  drivers/power/regulator/palmas_regulator.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/regulator/palmas_regulator.c
>> b/drivers/power/regulator/palmas_regulator.c
>> index cce7cd2..399f7a5 100644
>> --- a/drivers/power/regulator/palmas_regulator.c
>> +++ b/drivers/power/regulator/palmas_regulator.c
>> @@ -356,7 +356,7 @@ static int palmas_smps_probe(struct udevice *dev)
>>          case 8:
>>          case 9:
>>          case 10:
>> -            idx = dev->driver_data - 4;
>> +            idx = dev->driver_data - 3;
>>              uc_pdata->ctrl_reg = palmas_smps_ctrl[type][idx];
>>              uc_pdata->volt_reg = palmas_smps_volt[type][idx];
>>              break;
>>
>
diff mbox

Patch

diff --git a/drivers/power/regulator/palmas_regulator.c b/drivers/power/regulator/palmas_regulator.c
index cce7cd2..399f7a5 100644
--- a/drivers/power/regulator/palmas_regulator.c
+++ b/drivers/power/regulator/palmas_regulator.c
@@ -356,7 +356,7 @@  static int palmas_smps_probe(struct udevice *dev)
 		case 8:
 		case 9:
 		case 10:
-			idx = dev->driver_data - 4;
+			idx = dev->driver_data - 3;
 			uc_pdata->ctrl_reg = palmas_smps_ctrl[type][idx];
 			uc_pdata->volt_reg = palmas_smps_volt[type][idx];
 			break;