| Message ID | 8aeb4ecc-9c95-6a8e-c125-41e77cbe25a3@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Jaehoon Chung |
| Headers | show |
Hi, Am 25.01.2017 um 20:52 schrieb Heiner Kallweit: > Copied from amlogic/meson-gx.dtsi on Linux with the interrupt > definition removed. Is there any reason to not sync the full .dtsi file and its dependent headers from Linux like I did in my recent forward-port of Carlo's series? If there is a reason to remove the interrupt definitions, you should explain that here please. Regards, Andreas > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > v2: > - no changes > --- > arch/arm/dts/meson-gxbb.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/dts/meson-gxbb.dtsi b/arch/arm/dts/meson-gxbb.dtsi > index e502c24..3f357b4 100644 > --- a/arch/arm/dts/meson-gxbb.dtsi > +++ b/arch/arm/dts/meson-gxbb.dtsi > @@ -329,6 +329,24 @@ > #address-cells = <2>; > #size-cells = <2>; > ranges = <0x0 0x0 0x0 0xd0000000 0x0 0x200000>; > + > + sd_emmc_a: mmc@70000 { > + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; > + reg = <0x0 0x70000 0x0 0x2000>; > + status = "disabled"; > + }; > + > + sd_emmc_b: mmc@72000 { > + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; > + reg = <0x0 0x72000 0x0 0x2000>; > + status = "disabled"; > + }; > + > + sd_emmc_c: mmc@74000 { > + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; > + reg = <0x0 0x74000 0x0 0x2000>; > + status = "disabled"; > + }; > }; > > ethmac: ethernet@c9410000 { >
Am 26.01.2017 um 23:52 schrieb Andreas Färber: > Hi, > > Am 25.01.2017 um 20:52 schrieb Heiner Kallweit: >> Copied from amlogic/meson-gx.dtsi on Linux with the interrupt >> definition removed. > > Is there any reason to not sync the full .dtsi file and its dependent > headers from Linux like I did in my recent forward-port of Carlo's series? > AFAICS there is no support for members of the Meson GX family other than GXBB in mainline uboot yet. So I chose to extend what is available now. IMHO this dts tree structure can be added once support for other GX chips will be added. I tried to avoid adding unnecessary complexity to the driver patches. > If there is a reason to remove the interrupt definitions, you should > explain that here please. > The driver in uboot uses polling, so there's no need for irq definitions. > Regards, > Andreas > >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> --- >> v2: >> - no changes >> --- >> arch/arm/dts/meson-gxbb.dtsi | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm/dts/meson-gxbb.dtsi b/arch/arm/dts/meson-gxbb.dtsi >> index e502c24..3f357b4 100644 >> --- a/arch/arm/dts/meson-gxbb.dtsi >> +++ b/arch/arm/dts/meson-gxbb.dtsi >> @@ -329,6 +329,24 @@ >> #address-cells = <2>; >> #size-cells = <2>; >> ranges = <0x0 0x0 0x0 0xd0000000 0x0 0x200000>; >> + >> + sd_emmc_a: mmc@70000 { >> + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; >> + reg = <0x0 0x70000 0x0 0x2000>; >> + status = "disabled"; >> + }; >> + >> + sd_emmc_b: mmc@72000 { >> + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; >> + reg = <0x0 0x72000 0x0 0x2000>; >> + status = "disabled"; >> + }; >> + >> + sd_emmc_c: mmc@74000 { >> + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; >> + reg = <0x0 0x74000 0x0 0x2000>; >> + status = "disabled"; >> + }; >> }; >> >> ethmac: ethernet@c9410000 { >> > >
diff --git a/arch/arm/dts/meson-gxbb.dtsi b/arch/arm/dts/meson-gxbb.dtsi index e502c24..3f357b4 100644 --- a/arch/arm/dts/meson-gxbb.dtsi +++ b/arch/arm/dts/meson-gxbb.dtsi @@ -329,6 +329,24 @@ #address-cells = <2>; #size-cells = <2>; ranges = <0x0 0x0 0x0 0xd0000000 0x0 0x200000>; + + sd_emmc_a: mmc@70000 { + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; + reg = <0x0 0x70000 0x0 0x2000>; + status = "disabled"; + }; + + sd_emmc_b: mmc@72000 { + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; + reg = <0x0 0x72000 0x0 0x2000>; + status = "disabled"; + }; + + sd_emmc_c: mmc@74000 { + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; + reg = <0x0 0x74000 0x0 0x2000>; + status = "disabled"; + }; }; ethmac: ethernet@c9410000 {
Copied from amlogic/meson-gx.dtsi on Linux with the interrupt definition removed. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- v2: - no changes --- arch/arm/dts/meson-gxbb.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)