diff mbox

[1/1] package/nodejs: disable icu support for host build

Message ID 1484448867-29347-1-git-send-email-mr.zoltan.gyarmati@gmail.com
State Accepted
Commit 24d90db52a74dfb818e113acb34750338242823a
Headers show

Commit Message

Zoltan Gyarmati Jan. 15, 2017, 2:54 a.m. UTC
Apperently if both icu and nodejs enabled during the nodejs host build the
nodejs buildsystem gets confused by the icu version installed by Buildroot
(icu 58.2) and the one bundled with the nodejs source tree(icu 57),
which ends up in linking-time errors as:

"""
undefined reference to
`icu_58::NumberFormat::format(icu_58::StringPiece,
icu_58::UnicodeString&, icu_58::FieldPositionIterator*, UErrorCode&)
const'
"""
(note the icu_58 in the symbol name while the bundled icu version is 57)

 This patch disables the (not used) i18n support in the nodejs host build
config in order to fix the issue. The issue doesn't affect the target build of
nodejs.

Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
---
 package/nodejs/nodejs.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard Jan. 16, 2017, 12:22 p.m. UTC | #1
>>>>> "Zoltan" == Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com> writes:

 >  Apperently if both icu and nodejs enabled during the nodejs host build the

+are

Committed after adding references to the autobuilder failures, thanks.
diff mbox

Patch

diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 43b6169..82a012a 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -63,6 +63,7 @@  define HOST_NODEJS_CONFIGURE_CMDS
 		--without-dtrace \
 		--without-etw \
 		--shared-zlib \
+		--with-intl=none \
 	)
 endef