diff mbox

iputils: arping fails to set correct broadcast address

Message ID 1281692696.23856.37.camel@firesoul.comx.local
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Jesper Dangaard Brouer Aug. 13, 2010, 9:44 a.m. UTC 
From: Paul Martin <pm@debian.org>

There seems to have been introduced a bug in iputils release s20100418.

This patch is based upon git://www.linux-ipv6.org/gitroot/iputils.git
(git commit fe342ca3148)

The regression is caused by commit 56018bf1b3
 arping: Support link-layer type with larger link-layer address.

As reported by: Paul Martin <pm@debian.org> in Debian bugreport #585591.

 There's a logic error in the function that parses the interface's
 broadcast address, causing it not to fill the broadcast address array
 correctly.

Please apply.

Reported-by: Paul Martin <pm@debian.org>
Tested-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---
 arping.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

YOSHIFUJI Hideaki / 吉藤英明 Sept. 16, 2010, 8:28 a.m. UTC | #1 
Hello.

(4:59), Jesper Dangaard Brouer wrote:
> 
> From: Paul Martin<pm@debian.org>
> 
> There seems to have been introduced a bug in iputils release s20100418.
> 
> This patch is based upon git://www.linux-ipv6.org/gitroot/iputils.git
> (git commit fe342ca3148)
> 
> The regression is caused by commit 56018bf1b3
>   arping: Support link-layer type with larger link-layer address.
> 
> As reported by: Paul Martin<pm@debian.org>  in Debian bugreport #585591.
> 
>   There's a logic error in the function that parses the interface's
>   broadcast address, causing it not to fill the broadcast address array
>   correctly.
> 
> Please apply.
> 
> Reported-by: Paul Martin<pm@debian.org>
> Tested-by: Jesper Dangaard Brouer<hawk@comx.dk>
> Signed-off-by: Jesper Dangaard Brouer<hawk@comx.dk>

Applied.  Thank you very much!

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arping.c b/arping.c
index 9bd6927..2613a12 100644
--- a/arping.c
+++ b/arping.c
@@ -336,7 +336,7 @@  void set_device_broadcast(char *device, unsigned char *ba, size_t balen)
 	}
 
 	for (p = ba, ch = 0; p < ba + balen; p++, ch += 3)
-		*p++ = strtoul(brdcast->value + ch * 3, NULL, 16);
+		*p = strtoul(brdcast->value + ch, NULL, 16);
 
 	return;
 }