diff mbox

[U-Boot,v3,09/10] am335x_evm: enable usb ether gadget as it supports DM_ETH

Message ID 20161117090815.17226-10-mugunthanvnm@ti.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Mugunthan V N Nov. 17, 2016, 9:08 a.m. UTC 
Since usb ether gadget have support for driver model, so enable
usb ether gadget.

Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
---
 include/configs/am335x_evm.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Simon Glass Jan. 9, 2017, 8:45 p.m. UTC | #1 
On 17 November 2016 at 02:08, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> Since usb ether gadget have support for driver model, so enable
> usb ether gadget.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> ---
>  include/configs/am335x_evm.h | 3 ---
>  1 file changed, 3 deletions(-)

Applied to u-boot-dm, thanks!
Marek Vasut Jan. 9, 2017, 8:58 p.m. UTC | #2 
On 01/09/2017 09:45 PM, Simon Glass wrote:
> On 17 November 2016 at 02:08, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>> Since usb ether gadget have support for driver model, so enable
>> usb ether gadget.
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>> ---
>>  include/configs/am335x_evm.h | 3 ---
>>  1 file changed, 3 deletions(-)
> 
> Applied to u-boot-dm, thanks!
> 
Shouldn't this go through u-boot-ti ?
Tom Rini Jan. 9, 2017, 10:15 p.m. UTC | #3 
On Mon, Jan 09, 2017 at 09:58:03PM +0100, Marek Vasut wrote:
> On 01/09/2017 09:45 PM, Simon Glass wrote:
> > On 17 November 2016 at 02:08, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> >> Since usb ether gadget have support for driver model, so enable
> >> usb ether gadget.
> >>
> >> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> >> Reviewed-by: Tom Rini <trini@konsulko.com>
> >> ---
> >>  include/configs/am335x_evm.h | 3 ---
> >>  1 file changed, 3 deletions(-)
> > 
> > Applied to u-boot-dm, thanks!
> 
> Shouldn't this go through u-boot-ti ?

No, I reviewed it so it can just go via the other tree.  I am not a fan
of breaking up a series into N maintainers, so long as the maintainers
have acked/reviewed/etc the series.
diff mbox

Patch

diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
index 8e62248c73..91e02de91f 100644
--- a/include/configs/am335x_evm.h
+++ b/include/configs/am335x_evm.h
@@ -301,12 +301,9 @@ 
 #endif
 
 #ifdef CONFIG_USB_MUSB_GADGET
-/* Removing USB gadget and can be enabled adter adding support usb DM */
-#ifndef CONFIG_DM_ETH
 #define CONFIG_USB_ETHER
 #define CONFIG_USB_ETH_RNDIS
 #define CONFIG_USBNET_HOST_ADDR	"de:ad:be:af:00:00"
-#endif /* CONFIG_DM_ETH */
 #endif /* CONFIG_USB_MUSB_GADGET */
 
 /*