diff mbox

[U-Boot,3/6] udoo_neo: Staticize board_string()

Message ID 1480617461-9893-3-git-send-email-breno.lima@nxp.com
State Accepted
Commit 72d900bdbc8bf58d9dfb646ecfcc0882031034ae
Delegated to: Stefano Babic
Headers show

Commit Message

Breno Matheus Lima Dec. 1, 2016, 6:37 p.m. UTC 
Change board_string() function to static because it's being used locally.

Signed-off-by: Breno Lima <breno.lima@nxp.com>
---
 board/udoo/neo/neo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Dec. 5, 2016, 4:37 p.m. UTC | #1 
On Thu, Dec 1, 2016 at 4:37 PM, Breno Lima <breno.lima@nxp.com> wrote:
> Change board_string() function to static because it's being used locally.
>
> Signed-off-by: Breno Lima <breno.lima@nxp.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Stefano Babic Dec. 16, 2016, 9:13 a.m. UTC | #2 
On 01/12/2016 19:37, Breno Lima wrote:
> Change board_string() function to static because it's being used locally.
> 
> Signed-off-by: Breno Lima <breno.lima@nxp.com>
> ---
>  board/udoo/neo/neo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/udoo/neo/neo.c b/board/udoo/neo/neo.c
> index efe8605..cfeed6f 100644
> --- a/board/udoo/neo/neo.c
> +++ b/board/udoo/neo/neo.c
> @@ -176,7 +176,7 @@ int board_mmc_init(bd_t *bis)
>  	return fsl_esdhc_initialize(bis, &usdhc_cfg[0]);
>  }
>  
> -char *board_string(void)
> +static char *board_string(void)
>  {
>  	switch (get_board_value()) {
>  	case UDOO_NEO_TYPE_BASIC:
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/udoo/neo/neo.c b/board/udoo/neo/neo.c
index efe8605..cfeed6f 100644
--- a/board/udoo/neo/neo.c
+++ b/board/udoo/neo/neo.c
@@ -176,7 +176,7 @@  int board_mmc_init(bd_t *bis)
 	return fsl_esdhc_initialize(bis, &usdhc_cfg[0]);
 }
 
-char *board_string(void)
+static char *board_string(void)
 {
 	switch (get_board_value()) {
 	case UDOO_NEO_TYPE_BASIC: