Message ID | 1481032035-19018-1-git-send-email-niklass@axis.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Niklas Cassel <niklas.cassel@axis.com> Date: Tue, 6 Dec 2016 14:47:15 +0100 > From: Niklas Cassel <niklas.cassel@axis.com> > > From what I can tell, spin_lock(&priv->lock) is not needed, since the > phy_ethtool_ksettings_set call is not given the priv struct. > > phy_start_aneg takes the phydev->lock. Calls to phy_adjust_link > from phy_state_machine also takes the phydev->lock. ... > Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> Applied, but please always be explicit about what tree you are targetting this patch by properly annotating for it in your Subject line. In this case that would be "Subject: [PATCH net-next] ..."
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index d5a8122b6033..6ab7e2bdcadd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -406,9 +406,7 @@ stmmac_ethtool_set_link_ksettings(struct net_device *dev, return 0; } - spin_lock(&priv->lock); rc = phy_ethtool_ksettings_set(phy, cmd); - spin_unlock(&priv->lock); return rc; }