| Message ID | 091e32fb-ad85-4dc8-2864-f2b97141f097@strongswan.org |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Nov 29, 2016 at 05:05:20PM +0100, Tobias Brunner wrote: > When handling inbound packets, the two halves of the sequence number > stored on the skb are already in network order. > > Fixes: 7021b2e1cddd ("esp4: Switch to new AEAD interface") > Signed-off-by: Tobias Brunner <tobias@strongswan.org> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Thanks for catching this!
On Wed, Nov 30, 2016 at 05:58:27PM +0800, Herbert Xu wrote: > On Tue, Nov 29, 2016 at 05:05:20PM +0100, Tobias Brunner wrote: > > When handling inbound packets, the two halves of the sequence number > > stored on the skb are already in network order. > > > > Fixes: 7021b2e1cddd ("esp4: Switch to new AEAD interface") > > Signed-off-by: Tobias Brunner <tobias@strongswan.org> > > Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Applied to the ipsec tree, thanks!
diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index d95631d09248..20fb25e3027b 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4/esp4.c @@ -476,7 +476,7 @@ static int esp_input(struct xfrm_state *x, struct sk_buff *skb) esph = (void *)skb_push(skb, 4); *seqhi = esph->spi; esph->spi = esph->seq_no; - esph->seq_no = htonl(XFRM_SKB_CB(skb)->seq.input.hi); + esph->seq_no = XFRM_SKB_CB(skb)->seq.input.hi; aead_request_set_callback(req, 0, esp_input_done_esn, skb); }
When handling inbound packets, the two halves of the sequence number stored on the skb are already in network order. Fixes: 7021b2e1cddd ("esp4: Switch to new AEAD interface") Signed-off-by: Tobias Brunner <tobias@strongswan.org> --- net/ipv4/esp4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)