mbox

[GIT,PULL] ARM: keystone: add TI SCI protocol support for v4.10

Message ID e6b04eeb-ebfb-2da0-834b-1da440a35783@ti.com
State New
Headers show

Pull-request

https://github.com/t-kristo/linux-pm.git for-4.10-ti-sci-base

Message

Tero Kristo Oct. 27, 2016, 9:30 a.m. UTC
Hi Arnd, Olof, Kevin,

This pull introduces the TI SCI protocol support for keystone family of 
devices, targeted for v4.10 merge window. We discussed with Santosh 
(keystone maintainer) that it would probably be better that I'll be 
sending the pull requests for this directly, avoiding one extra step of 
merges.

-Tero


The following changes since commit 1001354ca34179f3db924eb66672442a173147dc:

   Linux 4.9-rc1 (2016-10-15 12:17:50 -0700)

are available in the git repository at:

   https://github.com/t-kristo/linux-pm.git for-4.10-ti-sci-base

for you to fetch changes up to 912cffb4ed8612dc99ee0251cc0c9785855162cd:

   firmware: ti_sci: Add support for reboot core service (2016-10-27 
12:09:12 +0300)

----------------------------------------------------------------
Nishanth Menon (5):
       Documentation: Add support for TI System Control Interface 
(TI-SCI) protocol
       firmware: Add basic support for TI System Control Interface 
(TI-SCI) protocol
       firmware: ti_sci: Add support for Device control
       firmware: ti_sci: Add support for Clock control
       firmware: ti_sci: Add support for reboot core service

  .../devicetree/bindings/arm/keystone/ti,sci.txt    |   81 +
  MAINTAINERS                                        |   10 +
  drivers/firmware/Kconfig                           |   15 +
  drivers/firmware/Makefile                          |    1 +
  drivers/firmware/ti_sci.c                          | 1991 
++++++++++++++++++++
  drivers/firmware/ti_sci.h                          |  492 +++++
  include/linux/soc/ti/ti_sci_protocol.h             |  249 +++
  7 files changed, 2839 insertions(+)
  create mode 100644 
Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
  create mode 100644 drivers/firmware/ti_sci.c
  create mode 100644 drivers/firmware/ti_sci.h
  create mode 100644 include/linux/soc/ti/ti_sci_protocol.h

Comments

Tero Kristo Nov. 28, 2016, 4:42 p.m. UTC | #1
Gentle ping on this, is anybody going to pull this one?

-Tero

On 27/10/16 12:30, Tero Kristo wrote:
> Hi Arnd, Olof, Kevin,
>
> This pull introduces the TI SCI protocol support for keystone family of
> devices, targeted for v4.10 merge window. We discussed with Santosh
> (keystone maintainer) that it would probably be better that I'll be
> sending the pull requests for this directly, avoiding one extra step of
> merges.
>
> -Tero
>
>
> The following changes since commit
> 1001354ca34179f3db924eb66672442a173147dc:
>
>   Linux 4.9-rc1 (2016-10-15 12:17:50 -0700)
>
> are available in the git repository at:
>
>   https://github.com/t-kristo/linux-pm.git for-4.10-ti-sci-base
>
> for you to fetch changes up to 912cffb4ed8612dc99ee0251cc0c9785855162cd:
>
>   firmware: ti_sci: Add support for reboot core service (2016-10-27
> 12:09:12 +0300)
>
> ----------------------------------------------------------------
> Nishanth Menon (5):
>       Documentation: Add support for TI System Control Interface
> (TI-SCI) protocol
>       firmware: Add basic support for TI System Control Interface
> (TI-SCI) protocol
>       firmware: ti_sci: Add support for Device control
>       firmware: ti_sci: Add support for Clock control
>       firmware: ti_sci: Add support for reboot core service
>
>  .../devicetree/bindings/arm/keystone/ti,sci.txt    |   81 +
>  MAINTAINERS                                        |   10 +
>  drivers/firmware/Kconfig                           |   15 +
>  drivers/firmware/Makefile                          |    1 +
>  drivers/firmware/ti_sci.c                          | 1991
> ++++++++++++++++++++
>  drivers/firmware/ti_sci.h                          |  492 +++++
>  include/linux/soc/ti/ti_sci_protocol.h             |  249 +++
>  7 files changed, 2839 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
>  create mode 100644 drivers/firmware/ti_sci.c
>  create mode 100644 drivers/firmware/ti_sci.h
>  create mode 100644 include/linux/soc/ti/ti_sci_protocol.h
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Arnd Bergmann Nov. 30, 2016, 4:43 p.m. UTC | #2
On Monday, November 28, 2016 6:42:41 PM CET Tero Kristo wrote:
> Gentle ping on this, is anybody going to pull this one?
> 
> -Tero
> 
> On 27/10/16 12:30, Tero Kristo wrote:
> > Hi Arnd, Olof, Kevin,
> >
> > This pull introduces the TI SCI protocol support for keystone family of
> > devices, targeted for v4.10 merge window. We discussed with Santosh
> > (keystone maintainer) that it would probably be better that I'll be
> > sending the pull requests for this directly, avoiding one extra step of
> > merges.
> 

Sorry for the delay. I just saw this pull request in the backlog
and had to take a closer look first. I probably would have commented
on a few details in a proper review, but overall this seems harmless
enough, so I've merged it into next/drivers in the end.

There was no branch description in
 https://github.com/t-kristo/linux-pm.git for-4.10-ti-sci-base
and I ended up taking something from the wiki. This is now the
commit I ended up with:

commit ba9cb7b9ffa4a4056158bc8570f1a851e4a6a8ae
Merge: e7541f9 912cffb
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Wed Nov 30 17:13:13 2016 +0100

    Merge branch 'for-4.10-ti-sci-base' of https://github.com/t-kristo/linux-pm into next/drivers
    
    Merge "ARM: keystone: add TI SCI protocol support for v4.10" from
    Tero Kristo:
    
    [description taken from http://processors.wiki.ti.com/index.php/TISCI
    
    Texas Instruments' Keystone generation System on Chips (SoC) starting
    with 66AK2G02, now include a dedicated SoC System Control entity called
    PMMC(Power Management Micro Controller) in line with ARM architecture
    recommendations. The function of this module is to integrate all system
    operations in a centralized location. Communication with the SoC System
    Control entity from various processing units like ARM/DSP occurs over
    Message Manager hardware block.
    
    ...
    
    Texas Instruments' System Control Interface defines the communication
    protocol between various processing entities to the System Control Entity
    on TI SoCs. This is a set of message formats and sequence of operations
    required to communicate and get system services processed from System
    Control entity in the SoC.]
    
    * 'for-4.10-ti-sci-base' of https://github.com/t-kristo/linux-pm:
      firmware: ti_sci: Add support for reboot core service
      firmware: ti_sci: Add support for Clock control
      firmware: ti_sci: Add support for Device control
      firmware: Add basic support for TI System Control Interface (TI-SCI) protocol
      Documentation: Add support for TI System Control Interface (TI-SCI) protocol

	Arnd
Tero Kristo Nov. 30, 2016, 5:59 p.m. UTC | #3
On 30/11/16 18:43, Arnd Bergmann wrote:
> On Monday, November 28, 2016 6:42:41 PM CET Tero Kristo wrote:
>> Gentle ping on this, is anybody going to pull this one?
>>
>> -Tero
>>
>> On 27/10/16 12:30, Tero Kristo wrote:
>>> Hi Arnd, Olof, Kevin,
>>>
>>> This pull introduces the TI SCI protocol support for keystone family of
>>> devices, targeted for v4.10 merge window. We discussed with Santosh
>>> (keystone maintainer) that it would probably be better that I'll be
>>> sending the pull requests for this directly, avoiding one extra step of
>>> merges.
>>
>
> Sorry for the delay. I just saw this pull request in the backlog
> and had to take a closer look first. I probably would have commented
> on a few details in a proper review, but overall this seems harmless
> enough, so I've merged it into next/drivers in the end.
>
> There was no branch description in
>  https://github.com/t-kristo/linux-pm.git for-4.10-ti-sci-base
> and I ended up taking something from the wiki. This is now the
> commit I ended up with:

Thanks Arnd, that looks good to me.

I'll figure out how to add branch description next time when I am going 
to be sending a pull-request directly to you guys.

-Tero

>
> commit ba9cb7b9ffa4a4056158bc8570f1a851e4a6a8ae
> Merge: e7541f9 912cffb
> Author: Arnd Bergmann <arnd@arndb.de>
> Date:   Wed Nov 30 17:13:13 2016 +0100
>
>     Merge branch 'for-4.10-ti-sci-base' of https://github.com/t-kristo/linux-pm into next/drivers
>
>     Merge "ARM: keystone: add TI SCI protocol support for v4.10" from
>     Tero Kristo:
>
>     [description taken from http://processors.wiki.ti.com/index.php/TISCI
>
>     Texas Instruments' Keystone generation System on Chips (SoC) starting
>     with 66AK2G02, now include a dedicated SoC System Control entity called
>     PMMC(Power Management Micro Controller) in line with ARM architecture
>     recommendations. The function of this module is to integrate all system
>     operations in a centralized location. Communication with the SoC System
>     Control entity from various processing units like ARM/DSP occurs over
>     Message Manager hardware block.
>
>     ...
>
>     Texas Instruments' System Control Interface defines the communication
>     protocol between various processing entities to the System Control Entity
>     on TI SoCs. This is a set of message formats and sequence of operations
>     required to communicate and get system services processed from System
>     Control entity in the SoC.]
>
>     * 'for-4.10-ti-sci-base' of https://github.com/t-kristo/linux-pm:
>       firmware: ti_sci: Add support for reboot core service
>       firmware: ti_sci: Add support for Clock control
>       firmware: ti_sci: Add support for Device control
>       firmware: Add basic support for TI System Control Interface (TI-SCI) protocol
>       Documentation: Add support for TI System Control Interface (TI-SCI) protocol
>
> 	Arnd
>
Arnd Bergmann Nov. 30, 2016, 9:09 p.m. UTC | #4
On Wednesday, November 30, 2016 7:59:26 PM CET Tero Kristo wrote:
> 
> Thanks Arnd, that looks good to me.
> 
> I'll figure out how to add branch description next time when I am going 
> to be sending a pull-request directly to you guys.
> 
> 

You should get a prompt when you sign the tag.

Actually my preference would be for you to forward this to Santosh:
There are a lot of little details to know about the submission
process to for arm-soc, and it's easier for us if fewer people
have to be aware of them.

	Arnd
Santosh Shilimkar Nov. 30, 2016, 10:47 p.m. UTC | #5
On 11/30/16 1:09 PM, Arnd Bergmann wrote:
> On Wednesday, November 30, 2016 7:59:26 PM CET Tero Kristo wrote:
>>
>> Thanks Arnd, that looks good to me.
>>
>> I'll figure out how to add branch description next time when I am going
>> to be sending a pull-request directly to you guys.
>>
>>
>
> You should get a prompt when you sign the tag.
>
> Actually my preference would be for you to forward this to Santosh:
> There are a lot of little details to know about the submission
> process to for arm-soc, and it's easier for us if fewer people
> have to be aware of them.
>
I can queue this up Arnd from next merge window onwards.

Regards,
Santosh