| Message ID | 20161124095506.25791-1-mlichvar@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Miroslav Lichvar <mlichvar@redhat.com> Date: Thu, 24 Nov 2016 10:55:06 +0100 > The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET > command and likewise it shouldn't require the CAP_NET_ADMIN capability. > > Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com> Good catch, applied, thanks.
❦ 24 novembre 2016 10:55 +0100, Miroslav Lichvar <mlichvar@redhat.com> : > The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET > command and likewise it shouldn't require the CAP_NET_ADMIN > capability. Could this patch be pushed to stable branches too?
From: Vincent Bernat <bernat@luffy.cx> Date: Sun, 25 Dec 2016 08:44:40 +0100 > ❦ 24 novembre 2016 10:55 +0100, Miroslav Lichvar <mlichvar@redhat.com> : > >> The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET >> command and likewise it shouldn't require the CAP_NET_ADMIN >> capability. > > Could this patch be pushed to stable branches too? Sure, queued up.
diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 9774898..047a175 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -2479,6 +2479,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr) case ETHTOOL_GET_TS_INFO: case ETHTOOL_GEEE: case ETHTOOL_GTUNABLE: + case ETHTOOL_GLINKSETTINGS: break; default: if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
The ETHTOOL_GLINKSETTINGS command is deprecating the ETHTOOL_GSET command and likewise it shouldn't require the CAP_NET_ADMIN capability. Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com> --- net/core/ethtool.c | 1 + 1 file changed, 1 insertion(+)