diff mbox

[ovs-dev,1/2] ovs-router: add missing newline in lookup output

Message ID 1480012720-4686-1-git-send-email-cascardo@redhat.com
State Accepted
Headers show

Commit Message

Thadeu Lima de Souza Cascardo Nov. 24, 2016, 6:38 p.m. UTC
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
---
 lib/ovs-router.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman Nov. 25, 2016, 1:56 p.m. UTC | #1
On Thu, Nov 24, 2016 at 04:38:39PM -0200, Thadeu Lima de Souza Cascardo wrote:
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>

Thanks,

I have pushed this and the following patch to master and branch-2.6.
It did not apply cleanly to branch-2.5. Please consider submitting a
backport to that and earlier branches if you think it is appropriate.
Thadeu Lima de Souza Cascardo Nov. 25, 2016, 2:50 p.m. UTC | #2
On Fri, Nov 25, 2016 at 02:56:23PM +0100, Simon Horman wrote:
> On Thu, Nov 24, 2016 at 04:38:39PM -0200, Thadeu Lima de Souza Cascardo wrote:
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> 
> Thanks,
> 
> I have pushed this and the following patch to master and branch-2.6.
> It did not apply cleanly to branch-2.5. Please consider submitting a
> backport to that and earlier branches if you think it is appropriate.

Hi, Simon.

The newline does not apply to 2.5. I thought about sending a different patch to
2.5 together with the other fix Ben just applied. Let me cook it and send it to
the mailing list.

Thanks.
Cascardo.
diff mbox

Patch

diff --git a/lib/ovs-router.c b/lib/ovs-router.c
index 637cad9..935b60a 100644
--- a/lib/ovs-router.c
+++ b/lib/ovs-router.c
@@ -402,7 +402,7 @@  ovs_router_lookup_cmd(struct unixctl_conn *conn, int argc OVS_UNUSED,
         struct ds ds = DS_EMPTY_INITIALIZER;
         ds_put_format(&ds, "src ");
         ipv6_format_mapped(&src, &ds);
-        ds_put_format(&ds, "gateway ");
+        ds_put_format(&ds, "\ngateway ");
         ipv6_format_mapped(&gw, &ds);
         ds_put_format(&ds, "\ndev %s\n", iface);
         unixctl_command_reply(conn, ds_cstr(&ds));