diff mbox

[U-Boot,v2] driver: net: ldpaa_eth: Fix missing bracket issue

Message ID 1478176510-16484-1-git-send-email-priyanka.jain@nxp.com
State Accepted
Delegated to: York Sun
Headers show

Commit Message

Priyanka Jain Nov. 3, 2016, 12:35 p.m. UTC 
Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
---
Changes for v2:
 Added signed-off-by

 drivers/net/ldpaa_eth/ldpaa_eth.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Joe Hershberger Nov. 15, 2016, 3:49 a.m. UTC | #1 
On Thu, Nov 3, 2016 at 7:35 AM, Priyanka Jain <priyanka.jain@nxp.com> wrote:
> Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

> ---
> Changes for v2:
>  Added signed-off-by
>
>  drivers/net/ldpaa_eth/ldpaa_eth.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c b/drivers/net/ldpaa_eth/ldpaa_eth.c
> index 75b2b6b..4e61700 100644
> --- a/drivers/net/ldpaa_eth/ldpaa_eth.c
> +++ b/drivers/net/ldpaa_eth/ldpaa_eth.c
> @@ -420,13 +420,14 @@ static int ldpaa_eth_open(struct eth_device *net_dev, bd_t *bd)
>                 goto err_dpmac_setup;
>
>  #ifdef CONFIG_PHYLIB
> -       if (priv->phydev)
> +       if (priv->phydev) {
>                 err = phy_startup(priv->phydev);
>                 if (err) {
>                         printf("%s: Could not initialize\n",
>                                priv->phydev->dev->name);
>                         goto err_dpamc_bind;
>                 }
> +       }
>  #else
>         priv->phydev = (struct phy_device *)malloc(sizeof(struct phy_device));
>         memset(priv->phydev, 0, sizeof(struct phy_device));
> --
> 1.7.4.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
York Sun Nov. 23, 2016, 12:53 a.m. UTC | #2 
On 11/03/2016 05:45 AM, Priyanka Jain wrote:
> Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> ---
> Changes for v2:
>  Added signed-off-by
>


Applied to fsl-qoriq, awaiting upstream. Thanks.

York
diff mbox

Patch

diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c b/drivers/net/ldpaa_eth/ldpaa_eth.c
index 75b2b6b..4e61700 100644
--- a/drivers/net/ldpaa_eth/ldpaa_eth.c
+++ b/drivers/net/ldpaa_eth/ldpaa_eth.c
@@ -420,13 +420,14 @@  static int ldpaa_eth_open(struct eth_device *net_dev, bd_t *bd)
 		goto err_dpmac_setup;
 
 #ifdef CONFIG_PHYLIB
-	if (priv->phydev)
+	if (priv->phydev) {
 		err = phy_startup(priv->phydev);
 		if (err) {
 			printf("%s: Could not initialize\n",
 			       priv->phydev->dev->name);
 			goto err_dpamc_bind;
 		}
+	}
 #else
 	priv->phydev = (struct phy_device *)malloc(sizeof(struct phy_device));
 	memset(priv->phydev, 0, sizeof(struct phy_device));