Message ID | cover.1479726397.git.horms+renesas@verge.net.au |
---|---|
State | New |
Headers | show |
Hello. On 11/21/2016 03:05 PM, Simon Horman wrote: > From: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > > This changes SDHI0 pin names for H3ULCB board > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > index 8d0ac076d8e2..6ffb0517421a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > @@ -163,13 +163,13 @@ > function = "avb"; > }; > > - sdhi0_pins_3v3: sd0_3v3 { > + sdhi0_pins: sd0 { > groups = "sdhi0_data4", "sdhi0_ctrl"; > function = "sdhi0"; > power-source = <3300>; > }; > > - sdhi0_pins_1v8: sd0_1v8 { > + sdhi0_pins_uhs: sd0 { I'm afraid the following will just override the props of the node above which is not what we ant. > groups = "sdhi0_data4", "sdhi0_ctrl"; > function = "sdhi0"; > power-source = <1800>; [...] MBR, Sergei
Hi Sergei, On 21.11.2016 16:13, Sergei Shtylyov wrote: > Hello. > > On 11/21/2016 03:05 PM, Simon Horman wrote: > >> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> >> This changes SDHI0 pin names for H3ULCB board >> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> --- >> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >> index 8d0ac076d8e2..6ffb0517421a 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >> @@ -163,13 +163,13 @@ >> function = "avb"; >> }; >> >> - sdhi0_pins_3v3: sd0_3v3 { >> + sdhi0_pins: sd0 { >> groups = "sdhi0_data4", "sdhi0_ctrl"; >> function = "sdhi0"; >> power-source = <3300>; >> }; >> >> - sdhi0_pins_1v8: sd0_1v8 { >> + sdhi0_pins_uhs: sd0 { > > I'm afraid the following will just override the props of the node > above which is not what we ant. Thank you for pointing to this. This is my typo. I will rework the patch to have different node names. Regards, Vladimir > >> groups = "sdhi0_data4", "sdhi0_ctrl"; >> function = "sdhi0"; >> power-source = <1800>; > [...] > > MBR, Sergei >
On 11/22/2016 2:22 PM, Vladimir Barinov wrote: >>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >>> >>> This changes SDHI0 pin names for H3ULCB board >>> >>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >>> --- >>> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> index 8d0ac076d8e2..6ffb0517421a 100644 >>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>> @@ -163,13 +163,13 @@ >>> function = "avb"; >>> }; >>> >>> - sdhi0_pins_3v3: sd0_3v3 { >>> + sdhi0_pins: sd0 { >>> groups = "sdhi0_data4", "sdhi0_ctrl"; >>> function = "sdhi0"; >>> power-source = <3300>; >>> }; >>> >>> - sdhi0_pins_1v8: sd0_1v8 { >>> + sdhi0_pins_uhs: sd0 { >> >> I'm afraid the following will just override the props of the node above >> which is not what we ant. > Thank you for pointing to this. > > This is my typo. > I will rework the patch to have different node names. The patch had been already merged by Simon and was posted a s apart of a pull request (if I don't mistake), so I guess an incremental patch needed now... > Regards, > Vladimir MBR, Sergei
Hi Sergei, On 22.11.2016 14:40, Sergei Shtylyov wrote: > On 11/22/2016 2:22 PM, Vladimir Barinov wrote: > >>>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >>>> >>>> This changes SDHI0 pin names for H3ULCB board >>>> >>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >>>> --- >>>> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++---- >>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>>> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>>> index 8d0ac076d8e2..6ffb0517421a 100644 >>>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >>>> @@ -163,13 +163,13 @@ >>>> function = "avb"; >>>> }; >>>> >>>> - sdhi0_pins_3v3: sd0_3v3 { >>>> + sdhi0_pins: sd0 { >>>> groups = "sdhi0_data4", "sdhi0_ctrl"; >>>> function = "sdhi0"; >>>> power-source = <3300>; >>>> }; >>>> >>>> - sdhi0_pins_1v8: sd0_1v8 { >>>> + sdhi0_pins_uhs: sd0 { >>> >>> I'm afraid the following will just override the props of the node >>> above >>> which is not what we ant. >> Thank you for pointing to this. >> >> This is my typo. >> I will rework the patch to have different node names. > > The patch had been already merged by Simon and was posted a s apart > of a pull request (if I don't mistake), so I guess an incremental > patch needed now... Thanks for clarification. I will make incremental patch. Regards, Vladimir > >> Regards, >> Vladimir > > MBR, Sergei >
On Tue, Nov 22, 2016 at 03:08:49PM +0300, Vladimir Barinov wrote: > Hi Sergei, > > On 22.11.2016 14:40, Sergei Shtylyov wrote: > >On 11/22/2016 2:22 PM, Vladimir Barinov wrote: > > > >>>>From: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > >>>> > >>>>This changes SDHI0 pin names for H3ULCB board > >>>> > >>>>Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > >>>>Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >>>>--- > >>>> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++---- > >>>> 1 file changed, 4 insertions(+), 4 deletions(-) > >>>> > >>>>diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > >>>>b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > >>>>index 8d0ac076d8e2..6ffb0517421a 100644 > >>>>--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > >>>>+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > >>>>@@ -163,13 +163,13 @@ > >>>> function = "avb"; > >>>> }; > >>>> > >>>>- sdhi0_pins_3v3: sd0_3v3 { > >>>>+ sdhi0_pins: sd0 { > >>>> groups = "sdhi0_data4", "sdhi0_ctrl"; > >>>> function = "sdhi0"; > >>>> power-source = <3300>; > >>>> }; > >>>> > >>>>- sdhi0_pins_1v8: sd0_1v8 { > >>>>+ sdhi0_pins_uhs: sd0 { > >>> > >>> I'm afraid the following will just override the props of the node > >>>above > >>>which is not what we ant. > >>Thank you for pointing to this. > >> > >>This is my typo. > >>I will rework the patch to have different node names. > > > > The patch had been already merged by Simon and was posted a s apart of > >a pull request (if I don't mistake), so I guess an incremental patch > >needed now... > Thanks for clarification. > > I will make incremental patch. Please do.
On Monday, November 21, 2016 1:05:10 PM CET Simon Horman wrote: > Second Round of Renesas ARM64 Based SoC DT Updates for v4.10 > > Enhancements: > * Add device nodes for PRR > * Add m3ulcb board > * Enable I2C on r8a7796/salvator-x board > * Enable SDHI0 on h3ulcb board > > Pulled into next/dt64, thanks! Arnd