[1/2] libidn2: new package

An implementation of the IDNA2008 specifications (RFC 5890, RFC 5891,
RFC 5892, RFC 5893)

Signed-off-by: Jeroen Roovers <jer@airfi.aero>
---
 package/Config.in            |  1 +
 package/libidn2/Config.in    |  5 +++++
 package/libidn2/libidn2.hash |  2 ++
 package/libidn2/libidn2.mk   | 12 ++++++++++++
 4 files changed, 20 insertions(+)
 create mode 100644 package/libidn2/Config.in
 create mode 100644 package/libidn2/libidn2.hash
 create mode 100644 package/libidn2/libidn2.mk

Hi Jeroen,

On Thu, Nov 03, 2016 at 12:05:11PM +0100, Jeroen Roovers wrote:
> diff --git a/package/libidn2/Config.in b/package/libidn2/Config.in
> new file mode 100644
> index 0000000..ce0a841
> --- /dev/null
> +++ b/package/libidn2/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_LIBIDN2
> +	bool "libidn2"
> +

A redundant empty line.

> +	help
> +	  An implementation of the IDNA2008 specifications (RFCs 5890, 5891, 5892, 5893)
> diff --git a/package/libidn2/libidn2.hash b/package/libidn2/libidn2.hash
> new file mode 100644
> index 0000000..5aedde0
> --- /dev/null
> +++ b/package/libidn2/libidn2.hash
> @@ -0,0 +1,2 @@
> +# Calculated locally after checking signature
> +sha256  3d301890bdbb137424f5ea495f82730a4b85b6a2549e47de3a34afebeac3e0e3  libidn2-0.10.tar.gz
> diff --git a/package/libidn2/libidn2.mk b/package/libidn2/libidn2.mk
> new file mode 100644
> index 0000000..7adc1d8
> --- /dev/null
> +++ b/package/libidn2/libidn2.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# libidn2
> +#
> +################################################################################
> +
> +LIBIDN2_VERSION = 0.10

Why not version 0.11?

> +LIBIDN2_SITE = ftp://alpha.gnu.org/gnu/libidn
> +LIBIDN2_SOURCE = libidn2-$(LIBIDN2_VERSION).tar.gz

This is the default.

> +LIBIDN2_INSTALL_STAGING = YES
> +
> +$(eval $(autotools-package))

baruch

On 3 November 2016 at 12:15, Baruch Siach <baruch@tkos.co.il> wrote:
>> +LIBIDN2_VERSION = 0.10
>
> Why not version 0.11?

Interesting. That didn't exist yet until a few moments ago.


Regards,
     jer

On 03-11-16 12:05, Jeroen Roovers wrote:
> An implementation of the IDNA2008 specifications (RFC 5890, RFC 5891,
> RFC 5892, RFC 5893)
> 
> Signed-off-by: Jeroen Roovers <jer@airfi.aero>
> ---
>  package/Config.in            |  1 +
>  package/libidn2/Config.in    |  5 +++++
>  package/libidn2/libidn2.hash |  2 ++
>  package/libidn2/libidn2.mk   | 12 ++++++++++++
>  4 files changed, 20 insertions(+)
>  create mode 100644 package/libidn2/Config.in
>  create mode 100644 package/libidn2/libidn2.hash
>  create mode 100644 package/libidn2/libidn2.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 9ed296f..7ffb756 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1198,6 +1198,7 @@ menu "Networking"
>  	source "package/libgsasl/Config.in"
>  	source "package/libhttpparser/Config.in"
>  	source "package/libidn/Config.in"
> +	source "package/libidn2/Config.in"
>  	source "package/libiscsi/Config.in"
>  	source "package/libldns/Config.in"
>  	source "package/libmbus/Config.in"
> diff --git a/package/libidn2/Config.in b/package/libidn2/Config.in
> new file mode 100644
> index 0000000..ce0a841
> --- /dev/null
> +++ b/package/libidn2/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_LIBIDN2
> +	bool "libidn2"
> +
> +	help
> +	  An implementation of the IDNA2008 specifications (RFCs 5890, 5891, 5892, 5893)

 The line is too long (wrap at 72 characters).

 Upstream URL is missing. Just use http://www.gnu.org/software/libidn/

 Shouldn't there be a BR2_PACKAGE_LIBIDN2_BINARY option like for libidn?
Although it looks like the binary is pretty small so not worth it.


> diff --git a/package/libidn2/libidn2.hash b/package/libidn2/libidn2.hash
> new file mode 100644
> index 0000000..5aedde0
> --- /dev/null
> +++ b/package/libidn2/libidn2.hash
> @@ -0,0 +1,2 @@
> +# Calculated locally after checking signature

 You should add the URL of the signature you checked.

> +sha256  3d301890bdbb137424f5ea495f82730a4b85b6a2549e47de3a34afebeac3e0e3  libidn2-0.10.tar.gz
> diff --git a/package/libidn2/libidn2.mk b/package/libidn2/libidn2.mk
> new file mode 100644
> index 0000000..7adc1d8
> --- /dev/null
> +++ b/package/libidn2/libidn2.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# libidn2
> +#
> +################################################################################
> +
> +LIBIDN2_VERSION = 0.10
> +LIBIDN2_SITE = ftp://alpha.gnu.org/gnu/libidn

 My first reaction was: shouldn't we instead upgrade libidn? But it looks like
the API is completely different. It's weird to use an alpha version for security
reasons, but that's what upstream curl does so OK.

> +LIBIDN2_SOURCE = libidn2-$(LIBIDN2_VERSION).tar.gz
> +LIBIDN2_INSTALL_STAGING = YES

 I haven't tried, but it looks like documentation can't be disabled and the
examples are always installed. Doesn't it need to be patched to allow building
in a minimal environment (i.e. without texinfo)?

 Regards,
 Arnout

> +
> +$(eval $(autotools-package))
>