diff mbox

[1/2] bridge: fix locking comment

Message ID 20100824160810.2fd5007c@nehalam
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Stephen Hemminger Aug. 24, 2010, 11:08 p.m. UTC
The carrier check is not called from work queue in current code.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Aug. 25, 2010, 11:39 p.m. UTC | #1
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Tue, 24 Aug 2010 16:08:10 -0700

> The carrier check is not called from work queue in current code.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/net/bridge/br_if.c	2010-08-20 15:17:26.306400002 -0700
+++ b/net/bridge/br_if.c	2010-08-20 15:18:20.826400002 -0700
@@ -61,11 +61,7 @@  static int port_cost(struct net_device *
 }
 
 
-/*
- * Check for port carrier transistions.
- * Called from work queue to allow for calling functions that
- * might sleep (such as speed check), and to debounce.
- */
+/* Check for port carrier transistions. */
 void br_port_carrier_check(struct net_bridge_port *p)
 {
 	struct net_device *dev = p->dev;