| Message ID | 20161021085246.17116-4-cyril.bur@au1.ibm.com |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, Oct 21, 2016 at 7:22 PM, Cyril Bur <cyril.bur@au1.ibm.com> wrote: > Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> > --- > external/pflash/pflash.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/external/pflash/pflash.c b/external/pflash/pflash.c > index 002d0dc..608220f 100644 > --- a/external/pflash/pflash.c > +++ b/external/pflash/pflash.c > @@ -743,6 +743,16 @@ int main(int argc, char *argv[]) > exit(1); > } > > + if (flashfilename && bmc_flash) { > + fprintf(stderr, "Filename or bmc flash but not both\n"); > + exit(1); > + } > + > + if (flashfilename && mtd) { > + fprintf(stderr, "Filename or mtd access but not both\n"); How do I specify a given mtd path?
On Fri, 2016-10-21 at 19:55 +1030, Joel Stanley wrote: > On Fri, Oct 21, 2016 at 7:22 PM, Cyril Bur <cyril.bur@au1.ibm.com> > wrote: > > Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> > > --- > > external/pflash/pflash.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/external/pflash/pflash.c b/external/pflash/pflash.c > > index 002d0dc..608220f 100644 > > --- a/external/pflash/pflash.c > > +++ b/external/pflash/pflash.c > > @@ -743,6 +743,16 @@ int main(int argc, char *argv[]) > > exit(1); > > } > > > > + if (flashfilename && bmc_flash) { > > + fprintf(stderr, "Filename or bmc flash but not > > both\n"); > > + exit(1); > > + } > > + > > + if (flashfilename && mtd) { > > + fprintf(stderr, "Filename or mtd access but not > > both\n"); > > How do I specify a given mtd path? Either do nothing and pflash will find it for you. 'Should just work' for both AMI and OpenBMC systems and of course the host. Or use '-F, -- flash-filename' and specify /dev/mtdx which should be a full PNOR, /dev/mtd7 on OpenBMC systems Cyril >
On Fri, Oct 21, 2016 at 7:59 PM, Cyril Bur <cyril.bur@au1.ibm.com> wrote: > On Fri, 2016-10-21 at 19:55 +1030, Joel Stanley wrote: >> On Fri, Oct 21, 2016 at 7:22 PM, Cyril Bur <cyril.bur@au1.ibm.com> >> wrote: >> > Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> >> > --- >> > external/pflash/pflash.c | 10 ++++++++++ >> > 1 file changed, 10 insertions(+) >> > >> > diff --git a/external/pflash/pflash.c b/external/pflash/pflash.c >> > index 002d0dc..608220f 100644 >> > --- a/external/pflash/pflash.c >> > +++ b/external/pflash/pflash.c >> > @@ -743,6 +743,16 @@ int main(int argc, char *argv[]) >> > exit(1); >> > } >> > >> > + if (flashfilename && bmc_flash) { >> > + fprintf(stderr, "Filename or bmc flash but not >> > both\n"); >> > + exit(1); >> > + } >> > + >> > + if (flashfilename && mtd) { >> > + fprintf(stderr, "Filename or mtd access but not >> > both\n"); >> >> How do I specify a given mtd path? > > Either do nothing and pflash will find it for you. 'Should just work' > for both AMI and OpenBMC systems and of course the host. Or use '-F, -- > flash-filename' and specify /dev/mtdx which should be a full PNOR, > /dev/mtd7 on OpenBMC systems If I use -F does it know that it's a mtd path and it needs to use the erase ioctl? Cheers, Joel
On Fri, 2016-10-21 at 20:05 +1030, Joel Stanley wrote: > On Fri, Oct 21, 2016 at 7:59 PM, Cyril Bur <cyril.bur@au1.ibm.com> > wrote: > > On Fri, 2016-10-21 at 19:55 +1030, Joel Stanley wrote: > > > On Fri, Oct 21, 2016 at 7:22 PM, Cyril Bur <cyril.bur@au1.ibm.com > > > > > > > wrote: > > > > Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> > > > > --- > > > > external/pflash/pflash.c | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > > > > > diff --git a/external/pflash/pflash.c > > > > b/external/pflash/pflash.c > > > > index 002d0dc..608220f 100644 > > > > --- a/external/pflash/pflash.c > > > > +++ b/external/pflash/pflash.c > > > > @@ -743,6 +743,16 @@ int main(int argc, char *argv[]) > > > > exit(1); > > > > } > > > > > > > > + if (flashfilename && bmc_flash) { > > > > + fprintf(stderr, "Filename or bmc flash but not > > > > both\n"); > > > > + exit(1); > > > > + } > > > > + > > > > + if (flashfilename && mtd) { > > > > + fprintf(stderr, "Filename or mtd access but not > > > > both\n"); > > > > > > How do I specify a given mtd path? > > > > Either do nothing and pflash will find it for you. 'Should just > > work' > > for both AMI and OpenBMC systems and of course the host. Or use '- > > F, -- > > flash-filename' and specify /dev/mtdx which should be a full PNOR, > > /dev/mtd7 on OpenBMC systems > > If I use -F does it know that it's a mtd path and it needs to use the > erase ioctl? > It does. Cyril > Cheers, > > Joel >
diff --git a/external/pflash/pflash.c b/external/pflash/pflash.c index 002d0dc..608220f 100644 --- a/external/pflash/pflash.c +++ b/external/pflash/pflash.c @@ -743,6 +743,16 @@ int main(int argc, char *argv[]) exit(1); } + if (flashfilename && bmc_flash) { + fprintf(stderr, "Filename or bmc flash but not both\n"); + exit(1); + } + + if (flashfilename && mtd) { + fprintf(stderr, "Filename or mtd access but not both\n"); + exit(1); + } + /* If file specified but not size, get size from file */ if (write_file && !write_size) {
Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> --- external/pflash/pflash.c | 10 ++++++++++ 1 file changed, 10 insertions(+)