[check_GNU_style.sh] More aggressively ignore dg-xxx directives

Hi all,

check_GNU_style.sh complains a lot about dg-* directives in the testsuite and in particular about line lengths.
There's nothing we can do about the directives and sometimes they're supposed to be long, in particular the scan-assembler
checks in dg-final.  Currently check_GNU_style.sh has code to avoid warning for dg-* directives but it's too weak, it doesn't
catch dg-final or dg-options directives.
This patch makes the code ignore all "{ dg-.*" lines for length purposes.
This eliminates a lot of false positives in my patches and didn't filter any legitimate warnings in my patches.

Ok for trunk?

Thanks,
Kyrill

2016-10-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * check_GNU_style.sh (col): Ignore dg-XXX directives for line length
     complaints.

On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote:
> check_GNU_style.sh complains a lot about dg-* directives in the testsuite and in particular about line lengths.
> There's nothing we can do about the directives and sometimes they're supposed to be long, in particular the scan-assembler
> checks in dg-final.  Currently check_GNU_style.sh has code to avoid warning for dg-* directives but it's too weak, it doesn't
> catch dg-final or dg-options directives.
> This patch makes the code ignore all "{ dg-.*" lines for length purposes.
> This eliminates a lot of false positives in my patches and didn't filter any legitimate warnings in my patches.

I wonder if we just shouldn't ignore all line lengths in testcases (or
perhaps any coding style whatsoever).  Some testcases are meant to be
formatted more-less according to our coding style (but, e.g.
/* PR tree-optimization/12345 */
comments never end with . and 2 spaces), except for dg- directives, but
others are entered in whatever form they came from the reporter.

	Jakub

On 10/11/2016 12:56 PM, Jakub Jelinek wrote:
> On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote:
>> check_GNU_style.sh complains a lot about dg-* directives in the testsuite and in particular about line lengths.
>> There's nothing we can do about the directives and sometimes they're supposed to be long, in particular the scan-assembler
>> checks in dg-final.  Currently check_GNU_style.sh has code to avoid warning for dg-* directives but it's too weak, it doesn't
>> catch dg-final or dg-options directives.
>> This patch makes the code ignore all "{ dg-.*" lines for length purposes.
>> This eliminates a lot of false positives in my patches and didn't filter any legitimate warnings in my patches.
>
> I wonder if we just shouldn't ignore all line lengths in testcases (or
> perhaps any coding style whatsoever).  Some testcases are meant to be
> formatted more-less according to our coding style (but, e.g.
> /* PR tree-optimization/12345 */
> comments never end with . and 2 spaces), except for dg- directives, but
> others are entered in whatever form they came from the reporter.

I agree, probably best not to check testcases for style (but then I 
don't trust automatic checkers anyway).


Bernd

On 11/10/16 11:56, Jakub Jelinek wrote:
> On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote:
>> check_GNU_style.sh complains a lot about dg-* directives in the testsuite and in particular about line lengths.
>> There's nothing we can do about the directives and sometimes they're supposed to be long, in particular the scan-assembler
>> checks in dg-final.  Currently check_GNU_style.sh has code to avoid warning for dg-* directives but it's too weak, it doesn't
>> catch dg-final or dg-options directives.
>> This patch makes the code ignore all "{ dg-.*" lines for length purposes.
>> This eliminates a lot of false positives in my patches and didn't filter any legitimate warnings in my patches.
> I wonder if we just shouldn't ignore all line lengths in testcases (or
> perhaps any coding style whatsoever).  Some testcases are meant to be
> formatted more-less according to our coding style (but, e.g.
> /* PR tree-optimization/12345 */
> comments never end with . and 2 spaces), except for dg- directives, but
> others are entered in whatever form they came from the reporter.

I would be up for ignoring the testsuite altogether in check_GNU_style.sh.
If there's consensus on this I can look into making that change.

Kyrill

> 	Jakub

On 10/11/2016 05:01 AM, Bernd Schmidt wrote:
> On 10/11/2016 12:56 PM, Jakub Jelinek wrote:
>> On Tue, Oct 11, 2016 at 11:47:21AM +0100, Kyrill Tkachov wrote:
>>> check_GNU_style.sh complains a lot about dg-* directives in the
>>> testsuite and in particular about line lengths.
>>> There's nothing we can do about the directives and sometimes they're
>>> supposed to be long, in particular the scan-assembler
>>> checks in dg-final.  Currently check_GNU_style.sh has code to avoid
>>> warning for dg-* directives but it's too weak, it doesn't
>>> catch dg-final or dg-options directives.
>>> This patch makes the code ignore all "{ dg-.*" lines for length
>>> purposes.
>>> This eliminates a lot of false positives in my patches and didn't
>>> filter any legitimate warnings in my patches.
>>
>> I wonder if we just shouldn't ignore all line lengths in testcases (or
>> perhaps any coding style whatsoever).  Some testcases are meant to be
>> formatted more-less according to our coding style (but, e.g.
>> /* PR tree-optimization/12345 */
>> comments never end with . and 2 spaces), except for dg- directives, but
>> others are entered in whatever form they came from the reporter.
>
> I agree, probably best not to check testcases for style (but then I
> don't trust automatic checkers anyway).
Agreed that checking testcases for style isn't desirable.


jeff