diff mbox

[16/17] Add LED expander mapping to Firestone DT

Message ID 1474058133-27363-17-git-send-email-tpearson@raptorengineering.com
State Changes Requested, archived
Headers show

Commit Message

Timothy Pearson Sept. 16, 2016, 8:35 p.m. UTC
There is a driver in the Linux kernel for the PCA9552 but it
is not yet devicetree-enabled.

Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
---
 arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |   54 ++++++++++++++++++++++--
 1 file changed, 50 insertions(+), 4 deletions(-)

Comments

Joel Stanley Sept. 23, 2016, 7:42 a.m. UTC | #1
On Sat, Sep 17, 2016 at 6:05 AM, Timothy Pearson
<tpearson@raptorengineering.com> wrote:
> There is a driver in the Linux kernel for the PCA9552 but it
> is not yet devicetree-enabled.

I will hold off until we have the driver working and can define some
bindings for it.

Cheers,

Joel
>
> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |   54 ++++++++++++++++++++++--
>  1 file changed, 50 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index 38f1b4b..8b25ba7 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -176,11 +176,57 @@
>         status = "okay";
>
>         leds@c0 {
> -               compatible = "pca,pca9552led";
> +               compatible = "nxp,pca9552";
>                 reg = <0x800000c0>;
> -               // led9 - led_fault_n
> -               // led10 - pwr_led_n
> -               // led11 - rear_id_led_n
> +
> +               centaur_present_0 {
> +                       //
> +               };
> +               centaur_present_1 {
> +                       //
> +               };
> +               centaur_present_2 {
> +                       //
> +               };
> +               centaur_present_3 {
> +                       //
> +               };
> +               centaur_present_4 {
> +                       //
> +               };
> +               centaur_present_5 {
> +                       //
> +               };
> +               centaur_present_6 {
> +                       //
> +               };
> +               centaur_present_7 {
> +                       //
> +               };
> +               no-connect-0 {
> +                       //
> +               };
> +               fault {
> +                       //
> +               };
> +               power {
> +                       //
> +               };
> +               identify-rear {
> +                       //
> +               };
> +               no-connect-1 {
> +                       //
> +               };
> +               power-supply-smbus-reset {
> +                       //
> +               };
> +               spi-vid-standby-reset {
> +                       //
> +               };
> +               apss-reset {
> +                       //
> +               };
>         };
>
>         rtc@d0 {
> --
> 1.7.9.5
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
Timothy Pearson Sept. 23, 2016, 3:05 p.m. UTC | #2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/23/2016 02:42 AM, Joel Stanley wrote:
> On Sat, Sep 17, 2016 at 6:05 AM, Timothy Pearson
> <tpearson@raptorengineering.com> wrote:
>> There is a driver in the Linux kernel for the PCA9552 but it
>> is not yet devicetree-enabled.
> 
> I will hold off until we have the driver working and can define some
> bindings for it.
> 
> Cheers,
> 
> Joel

This is reasonable.  The functions driven by this particular expander
are non-critical.

- -- 
Timothy Pearson
Raptor Engineering
+1 (415) 727-8645 (direct line)
+1 (512) 690-0200 (switchboard)
https://www.raptorengineering.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJX5USvAAoJEK+E3vEXDOFbuqsH/0HoLbsq8Nmc3Hyb+vQ7wQQp
JxifvYc7ptiWEuVNiu+fmYwKfbbrrylcmexQUBAqAhTL3uhy074TQorEXygdLgxq
6KwvX4g4T5olScwzU6oT7sGS58joEMJw7yF3NBFhrUHdVZNqgYz1bgzRp/MDDRDa
kqtenNjSL4LtYF5MdvUSsS1Jq1tlYqkB9hbqKcE9MbjXwBWC+8WaNj11NQJllfVw
3QQDGO1sCnHmlBbPUYBarRv1MVicus4U2V1X6Pph70LqT6RcekqL8ilW0t6ePYDq
LRkDx9WkPKk3binX+Ujyuld4MAQnCwzbgGh8j9sT2yRrht8UzMa9a9pK+Hru8Zo=
=fikF
-----END PGP SIGNATURE-----
diff mbox

Patch

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
index 38f1b4b..8b25ba7 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
@@ -176,11 +176,57 @@ 
 	status = "okay";
 
 	leds@c0 {
-		compatible = "pca,pca9552led";
+		compatible = "nxp,pca9552";
 		reg = <0x800000c0>;
-		// led9 - led_fault_n
-		// led10 - pwr_led_n
-		// led11 - rear_id_led_n
+
+		centaur_present_0 {
+			//
+		};
+		centaur_present_1 {
+			//
+		};
+		centaur_present_2 {
+			//
+		};
+		centaur_present_3 {
+			//
+		};
+		centaur_present_4 {
+			//
+		};
+		centaur_present_5 {
+			//
+		};
+		centaur_present_6 {
+			//
+		};
+		centaur_present_7 {
+			//
+		};
+		no-connect-0 {
+			//
+		};
+		fault {
+			//
+		};
+		power {
+			//
+		};
+		identify-rear {
+			//
+		};
+		no-connect-1 {
+			//
+		};
+		power-supply-smbus-reset {
+			//
+		};
+		spi-vid-standby-reset {
+			//
+		};
+		apss-reset {
+			//
+		};
 	};
 
 	rtc@d0 {