diff mbox

[08/16] Add missing LEDs to Firestone DT

Message ID 847945394.194630.1473971761780.JavaMail.zimbra@raptorengineeringinc.com
State Superseded, archived
Headers show

Commit Message

Timothy Pearson Sept. 15, 2016, 8:36 p.m. UTC 
---
 arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Joel Stanley Sept. 16, 2016, 1:41 a.m. UTC | #1 
On Fri, Sep 16, 2016 at 6:06 AM, Timothy Pearson
<tpearson@raptorengineering.com> wrote:
>
Missing commit message, s-o-b.

> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index ae1a633..4f04e76 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -2,6 +2,8 @@
>
>  #include "aspeed-g4.dtsi"
>
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
>  / {
>         model = "Firestone BMC";
>         compatible = "ibm,firestone-bmc", "aspeed,ast2400";
> @@ -19,6 +21,22 @@
>                 reg = < 0x40000000 0x10000000 >;
>         };
>
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               heartbeat {
> +                       gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>;
> +               };
> +
> +               power {
> +                       gpios = <&gpio ASPEED_GPIO(R, 5) GPIO_ACTIVE_LOW>;
> +               };

On barreleye in the dev-4.4 tree we have another property to ensure
these are kept in the same state on reboot. Do you want the same?

> +
> +               identify {
> +                       gpios = <&gpio ASPEED_GPIO(A, 2) GPIO_ACTIVE_LOW>;
> +               };
> +       };
> +
>         ahb {
>                 fmc@1e620000 {
>                         reg = < 0x1e620000 0x94
> --
> 1.7.9.5
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
diff mbox

Patch

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
index ae1a633..4f04e76 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
@@ -2,6 +2,8 @@ 
 
 #include "aspeed-g4.dtsi"
 
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
 / {
 	model = "Firestone BMC";
 	compatible = "ibm,firestone-bmc", "aspeed,ast2400";
@@ -19,6 +21,22 @@ 
 		reg = < 0x40000000 0x10000000 >;
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		heartbeat {
+			gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>;
+		};
+
+		power {
+			gpios = <&gpio ASPEED_GPIO(R, 5) GPIO_ACTIVE_LOW>;
+		};
+
+		identify {
+			gpios = <&gpio ASPEED_GPIO(A, 2) GPIO_ACTIVE_LOW>;
+		};
+	};
+
 	ahb {
 		fmc@1e620000 {
 			reg = < 0x1e620000 0x94