diff mbox

[ovs-dev] ovs-save: Use ${bridge} when dumping TLV map.

Message ID 1473643583-29890-1-git-send-email-jesse@kernel.org
State Accepted
Headers show

Commit Message

Jesse Gross Sept. 12, 2016, 1:26 a.m. UTC 
The script accidentally hardcoded the bridge name as 'br-int',
a leftover from testing.

Reported-by: Huanle Han <hanxueluo@gmail.com>
Signed-off-by: Jesse Gross <jesse@kernel.org>
---
 utilities/ovs-save | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff Sept. 15, 2016, 5:43 p.m. UTC | #1 
On Sun, Sep 11, 2016 at 06:26:23PM -0700, Jesse Gross wrote:
> The script accidentally hardcoded the bridge name as 'br-int',
> a leftover from testing.
> 
> Reported-by: Huanle Han <hanxueluo@gmail.com>
> Signed-off-by: Jesse Gross <jesse@kernel.org>

Acked-by: Ben Pfaff <blp@ovn.org>
Jesse Gross Sept. 15, 2016, 5:50 p.m. UTC | #2 
On Thu, Sep 15, 2016 at 10:43 AM, Ben Pfaff <blp@ovn.org> wrote:
> On Sun, Sep 11, 2016 at 06:26:23PM -0700, Jesse Gross wrote:
>> The script accidentally hardcoded the bridge name as 'br-int',
>> a leftover from testing.
>>
>> Reported-by: Huanle Han <hanxueluo@gmail.com>
>> Signed-off-by: Jesse Gross <jesse@kernel.org>
>
> Acked-by: Ben Pfaff <blp@ovn.org>

Thanks, applied to master, branch-2.6, and branch-2.5.
diff mbox

Patch

diff --git a/utilities/ovs-save b/utilities/ovs-save
index 4ae8fde..8b8dbf4 100755
--- a/utilities/ovs-save
+++ b/utilities/ovs-save
@@ -107,7 +107,7 @@  save_flows () {
 
     for bridge in "$@"; do
         echo -n "ovs-ofctl add-tlv-map ${bridge} '"
-        ovs-ofctl dump-tlv-map br-int | \
+        ovs-ofctl dump-tlv-map ${bridge} | \
         awk '/^ 0x/ {if (cnt != 0) printf ","; \
              cnt++;printf "{class="$1",type="$2",len="$3"}->"$4}'
         echo "'"