diff mbox

remove INSTALL file to have a clean git status

Message ID 1469724033-27105-1-git-send-email-nhofmeyr@sysmocom.de
State New
Headers show

Commit Message

Neels Hofmeyr July 28, 2016, 4:40 p.m. UTC 
From: Neels Hofmeyr <neels@hofmeyr.de>

The INSTALL file is being overwritten by autoreconf, but it is committed
as empty file. As a result, the INSTALL file always shows as modified.
Instead, remove INSTALL from git and ignore it.
---
 .gitignore | 1 +
 INSTALL    | 0
 2 files changed, 1 insertion(+)
 delete mode 100644 INSTALL

diff --git a/INSTALL b/INSTALL
deleted file mode 100644
index e69de29..0000000

Comments

Neels Hofmeyr Aug. 8, 2016, 2:49 p.m. UTC | #1 
On Fri, Jul 29, 2016 at 08:19:26PM -0400, Alexander Chemeris wrote:
> Really good idea. That has been annoying thing.

Yes -- let me flag it more prominently as an osmo-trx patch, maybe we can have
this merged one day :)

Merging patches to osmo-trx is currently TT's privilege & responsibility,
right? Ah, I also see some commits by Alexander... should I push this myself,
then? (I wonder whether I have push access)

~Neels

> On Jul 28, 2016 12:40, "Neels Hofmeyr" <nhofmeyr@sysmocom.de> wrote:
> 
> > From: Neels Hofmeyr <neels@hofmeyr.de>
> >
> > The INSTALL file is being overwritten by autoreconf, but it is committed
> > as empty file. As a result, the INSTALL file always shows as modified.
> > Instead, remove INSTALL from git and ignore it.
> > ---
> >  .gitignore | 1 +
> >  INSTALL    | 0
> >  2 files changed, 1 insertion(+)
> >  delete mode 100644 INSTALL
> >
> > diff --git a/.gitignore b/.gitignore
> > index e15c19b..d1a0b33 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -39,6 +39,7 @@ libtool
> >  ltmain.sh
> >  missing
> >  stamp-h1
> > +INSTALL
> >
> >  # vim
> >  *.sw?
> > diff --git a/INSTALL b/INSTALL
> > deleted file mode 100644
> > index e69de29..0000000
> > --
> > 2.1.4
> >
> >
Thomas Tsou Aug. 8, 2016, 6:57 p.m. UTC | #2 
On Mon, Aug 8, 2016 at 7:49 AM, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:
> On Fri, Jul 29, 2016 at 08:19:26PM -0400, Alexander Chemeris wrote:
>> Really good idea. That has been annoying thing.
>
> Yes -- let me flag it more prominently as an osmo-trx patch, maybe we can have
> this merged one day :)

Merged. And yes, please noticeably flag as osmo-trx.

  -TT
diff mbox

Patch

diff --git a/.gitignore b/.gitignore
index e15c19b..d1a0b33 100644
--- a/.gitignore
+++ b/.gitignore
@@ -39,6 +39,7 @@  libtool
 ltmain.sh
 missing
 stamp-h1
+INSTALL
 
 # vim
 *.sw?