| Message ID | 20160805004043.12424-1-joe@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
LGTM, thanks Acked-by: <diproiettod@vmware.com> 2016-08-04 17:40 GMT-07:00 Joe Stringer <joe@ovn.org>: > Previously we checked on the underlying interfaces rather than the vlan > interfaces to verify whether IPv6 connectivity is available; > occasionally this would fail on some systems. Wait on the VLAN IP > instead. > > Signed-off-by: Joe Stringer <joe@ovn.org> > --- > tests/system-traffic.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > index 666a14d44ff6..e9df90e27ac8 100644 > --- a/tests/system-traffic.at > +++ b/tests/system-traffic.at > @@ -113,7 +113,7 @@ ADD_VLAN(p1, at_ns1, 100, "fc00:1::2/96") > dnl Linux seems to take a little time to get its IPv6 stack in order. > Without > dnl waiting, we get occasional failures due to the following error: > dnl "connect: Cannot assign requested address" > -OVS_WAIT_UNTIL([ip netns exec at_ns0 ping6 -c 1 fc00::2]) > +OVS_WAIT_UNTIL([ip netns exec at_ns0 ping6 -c 1 fc00:1::2]) > > NS_CHECK_EXEC([at_ns0], [ping6 -q -c 3 -i 0.3 -w 2 fc00:1::2 | > FORMAT_PING], [0], [dnl > 3 packets transmitted, 3 received, 0% packet loss, time 0ms > -- > 2.9.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
On 4 August 2016 at 18:28, Daniele Di Proietto <diproiettod@ovn.org> wrote: > LGTM, thanks > > Acked-by: <diproiettod@vmware.com> Thanks, applied.
diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 666a14d44ff6..e9df90e27ac8 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -113,7 +113,7 @@ ADD_VLAN(p1, at_ns1, 100, "fc00:1::2/96") dnl Linux seems to take a little time to get its IPv6 stack in order. Without dnl waiting, we get occasional failures due to the following error: dnl "connect: Cannot assign requested address" -OVS_WAIT_UNTIL([ip netns exec at_ns0 ping6 -c 1 fc00::2]) +OVS_WAIT_UNTIL([ip netns exec at_ns0 ping6 -c 1 fc00:1::2]) NS_CHECK_EXEC([at_ns0], [ping6 -q -c 3 -i 0.3 -w 2 fc00:1::2 | FORMAT_PING], [0], [dnl 3 packets transmitted, 3 received, 0% packet loss, time 0ms
Previously we checked on the underlying interfaces rather than the vlan interfaces to verify whether IPv6 connectivity is available; occasionally this would fail on some systems. Wait on the VLAN IP instead. Signed-off-by: Joe Stringer <joe@ovn.org> --- tests/system-traffic.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)