Message ID | CAM_3v9+PG2CXHtG=sxE4E6dE=sPTeKZgN+fLy7KAG_KCQSSNRw@mail.gmail.com |
---|---|
State | Not Applicable |
Headers | show |
On Thu, Jul 28, 2016 at 01:29:42PM -0700, Guru Shetty wrote: > On 28 July 2016 at 11:37, Ben Pfaff <blp@ovn.org> wrote: > > > On Wed, Jul 27, 2016 at 11:28:24AM -0700, Nimay Desai wrote: > > > Added an IPv4 and MAC addresses management system to ovn-northd. When a > > logical > > > switch's other_config:subnet field is set, logical ports attached to that > > > switch that have the keyword "dynamic" in their addresses column will > > > automatically be allocated a globally unique MAC address/unused IPv4 > > address > > > within the provided subnet. The allocated address will populate the > > > dynamic_addresses column. This can be useful for a user who wants to > > deploy > > > many VM's or containers with networking capabilities, but does not care > > about > > > the specific MAC/IPv4 addresses that are assigned. > > > > > > Added tests in ovn.at for ipam. > > > > > > Signed-off-by: Nimay Desai <nimaydesai1@gmail.com> > > > > The code uses the abbreviations 'ipam' and 'macam' a lot. IPAM is a > > fairly common term but I don't know what macam stands for. I think it > > would be a good idea to explain both terms in comments. > > > > Do you think this incremental is helpful? Yes, thanks!
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 02b26bb..18756e9 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -62,8 +62,8 @@ static const char *default_sb_db(void); #define MAC_ADDR_PREFIX 0x0A0000000000ULL #define MAC_ADDR_SPACE 0xffffff -/* MAC address table of "struct eth_addr"s, that holds the MAC addresses - * allocated by the ipam. */ +/* MAC address management (macam) table of "struct eth_addr"s, that holds the + * MAC addresses allocated by the OVN ipam module. */ static struct hmap macam = HMAP_INITIALIZER(&macam); ^L