diff mbox

libgo patch committed: Update to 1.7rc3

Message ID yddh9bdycp3.fsf@CeBiTec.Uni-Bielefeld.DE
State New
Headers show

Commit Message

Rainer Orth July 25, 2016, 3:11 p.m. UTC 
Hi Ian,

> I have committed a patch to update libgo to the 1.7rc3 release
> candidate.  This is very close to the upcoming 1.7 release.  As usual
> with libgo updates, the patch is too large to include in this e-mail
> message.  I've appended the changes to the gccgo-specific directories.

this broke Solaris bootstrap:

/vol/gcc/src/hg/trunk/local/libgo/go/os/user/decls_solaris.go:24:46: error: reference to undefined identifier 'syscall.group'
 func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.group, buf *byte, buflen syscall.Size_t, result **syscall.group) int
                                              ^
/vol/gcc/src/hg/trunk/local/libgo/go/os/user/decls_solaris.go:24:104: error: reference to undefined identifier 'syscall.group'
 func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.group, buf *byte, buflen syscall.Size_t, result **syscall.group) int

                        ^
make[4]: *** [os/user.lo] Error 1

Easily fixed by the following patch:
There are also a couple of testsuite regressions I need to investigate.

	Rainer

Comments

Ian Lance Taylor July 26, 2016, 1:38 a.m. UTC | #1 
On Mon, Jul 25, 2016 at 8:11 AM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
>
>> I have committed a patch to update libgo to the 1.7rc3 release
>> candidate.  This is very close to the upcoming 1.7 release.  As usual
>> with libgo updates, the patch is too large to include in this e-mail
>> message.  I've appended the changes to the gccgo-specific directories.
>
> this broke Solaris bootstrap:
>
> /vol/gcc/src/hg/trunk/local/libgo/go/os/user/decls_solaris.go:24:46: error: reference to undefined identifier 'syscall.group'
>  func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.group, buf *byte, buflen syscall.Size_t, result **syscall.group) int
>                                               ^
> /vol/gcc/src/hg/trunk/local/libgo/go/os/user/decls_solaris.go:24:104: error: reference to undefined identifier 'syscall.group'
>  func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.group, buf *byte, buflen syscall.Size_t, result **syscall.group) int
>
>                         ^
> make[4]: *** [os/user.lo] Error 1
>
> Easily fixed by the following patch:

Sorry about that.  I committed the patch.  Thanks for sending it.

Ian
diff mbox

Patch

diff --git a/libgo/go/os/user/decls_solaris.go b/libgo/go/os/user/decls_solaris.go
--- a/libgo/go/os/user/decls_solaris.go
+++ b/libgo/go/os/user/decls_solaris.go
@@ -21,4 +21,4 @@  func libc_getpwuid_r(uid syscall.Uid_t, 
 func libc_getgrnam_r(name *byte, grp *syscall.Group, buf *byte, buflen syscall.Size_t, result **syscall.Group) int
 
 //extern __posix_getgrgid_r
-func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.group, buf *byte, buflen syscall.Size_t, result **syscall.group) int
+func libc_getgrgid_r(gid syscall.Gid_t, grp *syscall.Group, buf *byte, buflen syscall.Size_t, result **syscall.Group) int