| Message ID | 1469189462-29784-1-git-send-email-breno.lima@nxp.com |
|---|---|
| State | Accepted |
| Commit | 98b040c9889bc23a7a0007853d52ebb07e28de76 |
| Delegated to: | Stefano Babic |
| Headers | show |
On Fri, Jul 22, 2016 at 9:11 AM, Breno Lima <breno.lima@nxp.com> wrote: > It's not necessary to use the is_cpu_type function, there is a macro in > sys_proto.h already implemented. > > Signed-off-by: Breno Lima <breno.lima@nxp.com> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
On 22/07/2016 14:11, Breno Lima wrote: > It's not necessary to use the is_cpu_type function, there is a macro in > sys_proto.h already implemented. > > Signed-off-by: Breno Lima <breno.lima@nxp.com> > --- > board/wandboard/wandboard.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c > index 8340dd1..d7c1142 100644 > --- a/board/wandboard/wandboard.c > +++ b/board/wandboard/wandboard.c > @@ -390,7 +390,7 @@ int board_late_init(void) > #endif > > #ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG > - if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D)) > + if (is_mx6dq()) > setenv("board_rev", "MX6Q"); > else > setenv("board_rev", "MX6DL"); > @@ -409,7 +409,7 @@ int board_init(void) > gd->bd->bi_boot_params = PHYS_SDRAM + 0x100; > > setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6dl_i2c2_pad_info); > - if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D)) > + if (is_mx6dq()) > setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6q_i2c2_pad_info); > else > setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6dl_i2c2_pad_info); > Applied to u-boot-imx, thanks ! Best regards, Stefano Babic
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c index 8340dd1..d7c1142 100644 --- a/board/wandboard/wandboard.c +++ b/board/wandboard/wandboard.c @@ -390,7 +390,7 @@ int board_late_init(void) #endif #ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG - if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D)) + if (is_mx6dq()) setenv("board_rev", "MX6Q"); else setenv("board_rev", "MX6DL"); @@ -409,7 +409,7 @@ int board_init(void) gd->bd->bi_boot_params = PHYS_SDRAM + 0x100; setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6dl_i2c2_pad_info); - if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D)) + if (is_mx6dq()) setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6q_i2c2_pad_info); else setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6dl_i2c2_pad_info);
It's not necessary to use the is_cpu_type function, there is a macro in sys_proto.h already implemented. Signed-off-by: Breno Lima <breno.lima@nxp.com> --- board/wandboard/wandboard.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)