Message ID | 1468905142-12539-1-git-send-email-sivadur@xilinx.com |
---|---|
State | Accepted |
Commit | 4d25507f3df9b7c06e04b40b6d42f895493c5435 |
Delegated to: | Michal Simek |
Headers | show |
Hi Tom, On 19.7.2016 07:12, Siva Durga Prasad Paladugu wrote: > Move config option CONFIG_SYS_NO_FLASH as Kconfig > option. All the boards which needs to enable this > option can be done through defconfigs > > Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> > --- > Changes for v2: > - No changes > --- > common/Kconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/common/Kconfig b/common/Kconfig > index 8adc821..46e7173 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -197,3 +197,9 @@ config CONSOLE_RECORD_IN_SIZE > tstc() and getc() will use this in preference to real device input. > The buffer is allocated immediately after the malloc() region is > ready. > + > +config SYS_NO_FLASH > + bool "Disable support for parallel NOR flash" > + default n > + help > + This option is used to disable support for parallel NOR flash. > Do you want to take this patch to your tree? Or should I take it to my tree with others patches which remove this option for zynq boards? Thanks, Michal
On Thu, Jul 21, 2016 at 01:51:20PM +0200, Michal Simek wrote: > Hi Tom, > > On 19.7.2016 07:12, Siva Durga Prasad Paladugu wrote: > > Move config option CONFIG_SYS_NO_FLASH as Kconfig > > option. All the boards which needs to enable this > > option can be done through defconfigs > > > > Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> > > --- > > Changes for v2: > > - No changes > > --- > > common/Kconfig | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/common/Kconfig b/common/Kconfig > > index 8adc821..46e7173 100644 > > --- a/common/Kconfig > > +++ b/common/Kconfig > > @@ -197,3 +197,9 @@ config CONSOLE_RECORD_IN_SIZE > > tstc() and getc() will use this in preference to real device input. > > The buffer is allocated immediately after the malloc() region is > > ready. > > + > > +config SYS_NO_FLASH > > + bool "Disable support for parallel NOR flash" > > + default n > > + help > > + This option is used to disable support for parallel NOR flash. > > > > Do you want to take this patch to your tree? > Or should I take it to my tree with others patches which remove this > option for zynq boards? Is it blocking other changes? If no, I'll grab it probably post -rc2 and migrate all config files, if yes, um, if we can grab this now and migrate later without adding a ton of warnings, we can go that way. Thanks!
On 21.7.2016 16:46, Tom Rini wrote: > On Thu, Jul 21, 2016 at 01:51:20PM +0200, Michal Simek wrote: >> Hi Tom, >> >> On 19.7.2016 07:12, Siva Durga Prasad Paladugu wrote: >>> Move config option CONFIG_SYS_NO_FLASH as Kconfig >>> option. All the boards which needs to enable this >>> option can be done through defconfigs >>> >>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> >>> --- >>> Changes for v2: >>> - No changes >>> --- >>> common/Kconfig | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/common/Kconfig b/common/Kconfig >>> index 8adc821..46e7173 100644 >>> --- a/common/Kconfig >>> +++ b/common/Kconfig >>> @@ -197,3 +197,9 @@ config CONSOLE_RECORD_IN_SIZE >>> tstc() and getc() will use this in preference to real device input. >>> The buffer is allocated immediately after the malloc() region is >>> ready. >>> + >>> +config SYS_NO_FLASH >>> + bool "Disable support for parallel NOR flash" >>> + default n >>> + help >>> + This option is used to disable support for parallel NOR flash. >>> >> >> Do you want to take this patch to your tree? >> Or should I take it to my tree with others patches which remove this >> option for zynq boards? > > Is it blocking other changes? If no, I'll grab it probably post -rc2 > and migrate all config files, if yes, um, if we can grab this now and > migrate later without adding a ton of warnings, we can go that way. There are 2 follow up patches which depends on this one. http://lists.denx.de/pipermail/u-boot/2016-July/260970.html http://lists.denx.de/pipermail/u-boot/2016-July/260972.html The point here that they are removing board files for 4 boards. But if you want to do it after rc2 I am fine with it. Thanks, Michal
On Thu, Jul 21, 2016 at 04:58:18PM +0200, Michal Simek wrote: > On 21.7.2016 16:46, Tom Rini wrote: > > On Thu, Jul 21, 2016 at 01:51:20PM +0200, Michal Simek wrote: > >> Hi Tom, > >> > >> On 19.7.2016 07:12, Siva Durga Prasad Paladugu wrote: > >>> Move config option CONFIG_SYS_NO_FLASH as Kconfig > >>> option. All the boards which needs to enable this > >>> option can be done through defconfigs > >>> > >>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> > >>> --- > >>> Changes for v2: > >>> - No changes > >>> --- > >>> common/Kconfig | 6 ++++++ > >>> 1 file changed, 6 insertions(+) > >>> > >>> diff --git a/common/Kconfig b/common/Kconfig > >>> index 8adc821..46e7173 100644 > >>> --- a/common/Kconfig > >>> +++ b/common/Kconfig > >>> @@ -197,3 +197,9 @@ config CONSOLE_RECORD_IN_SIZE > >>> tstc() and getc() will use this in preference to real device input. > >>> The buffer is allocated immediately after the malloc() region is > >>> ready. > >>> + > >>> +config SYS_NO_FLASH > >>> + bool "Disable support for parallel NOR flash" > >>> + default n > >>> + help > >>> + This option is used to disable support for parallel NOR flash. > >>> > >> > >> Do you want to take this patch to your tree? > >> Or should I take it to my tree with others patches which remove this > >> option for zynq boards? > > > > Is it blocking other changes? If no, I'll grab it probably post -rc2 > > and migrate all config files, if yes, um, if we can grab this now and > > migrate later without adding a ton of warnings, we can go that way. > > > There are 2 follow up patches which depends on this one. > > http://lists.denx.de/pipermail/u-boot/2016-July/260970.html > http://lists.denx.de/pipermail/u-boot/2016-July/260972.html > > The point here that they are removing board files for 4 boards. But if > you want to do it after rc2 I am fine with it. Go ahead and bring it all in your tree (and build a bunch of arm) and if it looks OK there, I'll take it now. Thanks!
On 21.7.2016 21:14, Tom Rini wrote: > On Thu, Jul 21, 2016 at 04:58:18PM +0200, Michal Simek wrote: >> On 21.7.2016 16:46, Tom Rini wrote: >>> On Thu, Jul 21, 2016 at 01:51:20PM +0200, Michal Simek wrote: >>>> Hi Tom, >>>> >>>> On 19.7.2016 07:12, Siva Durga Prasad Paladugu wrote: >>>>> Move config option CONFIG_SYS_NO_FLASH as Kconfig >>>>> option. All the boards which needs to enable this >>>>> option can be done through defconfigs >>>>> >>>>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> >>>>> --- >>>>> Changes for v2: >>>>> - No changes >>>>> --- >>>>> common/Kconfig | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/common/Kconfig b/common/Kconfig >>>>> index 8adc821..46e7173 100644 >>>>> --- a/common/Kconfig >>>>> +++ b/common/Kconfig >>>>> @@ -197,3 +197,9 @@ config CONSOLE_RECORD_IN_SIZE >>>>> tstc() and getc() will use this in preference to real device input. >>>>> The buffer is allocated immediately after the malloc() region is >>>>> ready. >>>>> + >>>>> +config SYS_NO_FLASH >>>>> + bool "Disable support for parallel NOR flash" >>>>> + default n >>>>> + help >>>>> + This option is used to disable support for parallel NOR flash. >>>>> >>>> >>>> Do you want to take this patch to your tree? >>>> Or should I take it to my tree with others patches which remove this >>>> option for zynq boards? >>> >>> Is it blocking other changes? If no, I'll grab it probably post -rc2 >>> and migrate all config files, if yes, um, if we can grab this now and >>> migrate later without adding a ton of warnings, we can go that way. >> >> >> There are 2 follow up patches which depends on this one. >> >> http://lists.denx.de/pipermail/u-boot/2016-July/260970.html >> http://lists.denx.de/pipermail/u-boot/2016-July/260972.html >> >> The point here that they are removing board files for 4 boards. But if >> you want to do it after rc2 I am fine with it. > > Go ahead and bring it all in your tree (and build a bunch of arm) and if > it looks OK there, I'll take it now. Thanks! > ok. Applied to xilinx tree. Thanks, Michal
diff --git a/common/Kconfig b/common/Kconfig index 8adc821..46e7173 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -197,3 +197,9 @@ config CONSOLE_RECORD_IN_SIZE tstc() and getc() will use this in preference to real device input. The buffer is allocated immediately after the malloc() region is ready. + +config SYS_NO_FLASH + bool "Disable support for parallel NOR flash" + default n + help + This option is used to disable support for parallel NOR flash.
Move config option CONFIG_SYS_NO_FLASH as Kconfig option. All the boards which needs to enable this option can be done through defconfigs Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> --- Changes for v2: - No changes --- common/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+)