Message ID | 2942868.C3caybiHGj@e108577-lin |
---|---|
State | New |
Headers | show |
Hi Thomas, On 14/07/16 10:12, Thomas Preudhomme wrote: > This patch fixes a syntax error in the dg-do selector of pr42574.c: it is > missing the target keyword, with the following boolean expression enclosed in > curly braces. Test fails to be run without this patch and successfully pass > with it. Patch is in attachment. > > ChangeLog entry is as follows: > > > *** gcc/testsuite/ChangeLog *** > > 2016-07-13 Thomas Preud'homme <thomas.preudhomme@arm.com> > > * gcc.target/arm/pr42574.c: Add missing target keyword for the dg-do > selector and enclose boolean expression in curly braces. > > > Is this ok for trunk? Ok. I'd say this is an obvious change. Thanks, Kyrill > Best regards, > > Thomas
On Thursday 14 July 2016 10:14:52 Kyrill Tkachov wrote: > Hi Thomas, > > On 14/07/16 10:12, Thomas Preudhomme wrote: > > This patch fixes a syntax error in the dg-do selector of pr42574.c: it is > > missing the target keyword, with the following boolean expression enclosed > > in curly braces. Test fails to be run without this patch and successfully > > pass with it. Patch is in attachment. > > > > ChangeLog entry is as follows: > > > > > > *** gcc/testsuite/ChangeLog *** > > > > 2016-07-13 Thomas Preud'homme <thomas.preudhomme@arm.com> > > > > * gcc.target/arm/pr42574.c: Add missing target keyword for the > > dg-do > > selector and enclose boolean expression in curly braces. > > > > Is this ok for trunk? > > Ok. I'd say this is an obvious change. Err indeed, long time I did not have one. Thanks. Thomas
diff --git a/gcc/testsuite/gcc.target/arm/pr42574.c b/gcc/testsuite/gcc.target/arm/pr42574.c index e3476f37788a2b3144454aef04a9b45c0b4ac398..d3d6b5d32e5826abf1017b823a9e271383daf09d 100644 --- a/gcc/testsuite/gcc.target/arm/pr42574.c +++ b/gcc/testsuite/gcc.target/arm/pr42574.c @@ -1,4 +1,4 @@ -/* { dg-do compile { arm_thumb1_ok && { ! arm_thumb1_movt_ok } } } */ +/* { dg-do compile { target { arm_thumb1_ok && { ! arm_thumb1_movt_ok } } } } */ /* { dg-options "-mthumb -Os -fpic" } */ /* { dg-require-effective-target fpic } */ /* Make sure the address of glob.c is calculated only once and using