diff mbox

net: ethernet: fix odd_ptr_err.cocci warnings

Message ID alpine.DEB.2.10.1606211201310.2882@hadrien
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Julia Lawall June 21, 2016, 10:03 a.m. UTC 
PTR_ERR should normally access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Tien Hock Loh <thloh@altera.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

This patch refers to the following code:

url:
https://github.com/0day-ci/linux/commits/thloh-altera-com/net-ethernet-Add-T
SE-PCS-support-to-dwmac-socfpga/20160621-164854

 dwmac-socfpga.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller June 23, 2016, 7:21 p.m. UTC | #1 
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Tue, 21 Jun 2016 12:03:28 +0200 (CEST)

> PTR_ERR should normally access the value just tested by IS_ERR
> 
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> 
> CC: Tien Hock Loh <thloh@altera.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

This doesn't apply to any of my tree(s).
diff mbox

Patch

--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -224,7 +224,7 @@  static int socfpga_dwmac_parse_data(stru
 				dev_err(dev,
 					"%s: ERROR: failed mapping tse control port\n",
 					__func__);
-				return PTR_ERR(dwmac->pcs.sgmii_adapter_base);
+				return PTR_ERR(dwmac->pcs.tse_pcs_base);
 			}
 		}
 	}