diff mbox

test-skeleton.c: xmalloc, xcalloc, xrealloc are potentially unused

Message ID 20160622151841.6E28E41C3910C@oldenburg.str.redhat.com
State New
Headers show

Commit Message

Florian Weimer June 22, 2016, 3:18 p.m. UTC 
__attribute__ ((used)) means that the function has to be
emitted in assembly because it is referenced in ways the
compiler cannot detect (such as asm statements, or some
post-processing on the generated assembly).

The unused attribute needs to come first, otherwise it is
applied to the return type and not the function definition.

2016-06-22  Florian Weimer  <fweimer@redhat.com>

	* test-skeleton.c (xmalloc, xcalloc, xrealloc): Mark as
	potentially unused.

Comments

Mike Frysinger June 22, 2016, 3:49 p.m. UTC | #1 
On 22 Jun 2016 17:18, Florian Weimer wrote:
> __attribute__ ((used)) means that the function has to be
> emitted in assembly because it is referenced in ways the
> compiler cannot detect (such as asm statements, or some
> post-processing on the generated assembly).
> 
> The unused attribute needs to come first, otherwise it is
> applied to the return type and not the function definition.

ok
-mike
diff mbox

Patch

diff --git a/test-skeleton.c b/test-skeleton.c
index 49808b3..0be4af1 100644
--- a/test-skeleton.c
+++ b/test-skeleton.c
@@ -78,8 +78,8 @@  oom_error (const char *fn, size_t size)
 }
 
 /* Allocate N bytes of memory dynamically, with error checking.  */
+__attribute__ ((unused))
 static void *
-__attribute__ ((used))
 xmalloc (size_t n)
 {
   void *p;
@@ -91,8 +91,8 @@  xmalloc (size_t n)
 }
 
 /* Allocate memory for N elements of S bytes, with error checking.  */
+__attribute__ ((unused))
 static void *
-__attribute__ ((used))
 xcalloc (size_t n, size_t s)
 {
   void *p;
@@ -105,8 +105,8 @@  xcalloc (size_t n, size_t s)
 
 /* Change the size of an allocated block of memory P to N bytes,
    with error checking.  */
+__attribute__ ((unused))
 static void *
-__attribute__ ((used))
 xrealloc (void *p, size_t n)
 {
   p = realloc (p, n);