| Message ID | c046e75506310e1bdbee79fec44f3dc2015bf667.1463145139.git.zackw@panix.com |
|---|---|
| State | New |
| Headers | show |
On Fri, May 13, 2016 at 6:26 AM, Zack Weinberg <zackw@panix.com> wrote: > This file was added to sysdeps/generic/bits in 2012. This appears to have > been an oversight, as the entire sysdeps/generic/bits directory was moved to > the top level in 2005. Accordingly the generic bits/hwcap.h belongs there > too. > > ChangeLog: > * sysdeps/generic/bits/hwcap.h: Move to top-level bits/ directory. Looks good to me.
On Fri, May 13, 2016 at 9:34 AM, H.J. Lu <hjl.tools@gmail.com> wrote: > On Fri, May 13, 2016 at 6:26 AM, Zack Weinberg <zackw@panix.com> wrote: >> This file was added to sysdeps/generic/bits in 2012. This appears to have >> been an oversight, as the entire sysdeps/generic/bits directory was moved to >> the top level in 2005. Accordingly the generic bits/hwcap.h belongs there >> too. >> >> ChangeLog: >> * sysdeps/generic/bits/hwcap.h: Move to top-level bits/ directory. > > Looks good to me. Gonna need someone to check this and any other good-as-is pieces in. zw
On Fri, May 13, 2016 at 12:42 PM, Zack Weinberg <zackw@panix.com> wrote: > On Fri, May 13, 2016 at 9:34 AM, H.J. Lu <hjl.tools@gmail.com> wrote: >> On Fri, May 13, 2016 at 6:26 AM, Zack Weinberg <zackw@panix.com> wrote: >>> This file was added to sysdeps/generic/bits in 2012. This appears to have >>> been an oversight, as the entire sysdeps/generic/bits directory was moved to >>> the top level in 2005. Accordingly the generic bits/hwcap.h belongs there >>> too. >>> >>> ChangeLog: >>> * sysdeps/generic/bits/hwcap.h: Move to top-level bits/ directory. >> >> Looks good to me. > > Gonna need someone to check this and any other good-as-is pieces in. Ping?
On Wed, Jun 22, 2016 at 4:41 AM, Zack Weinberg <zackw@panix.com> wrote: > On Fri, May 13, 2016 at 12:42 PM, Zack Weinberg <zackw@panix.com> wrote: >> On Fri, May 13, 2016 at 9:34 AM, H.J. Lu <hjl.tools@gmail.com> wrote: >>> On Fri, May 13, 2016 at 6:26 AM, Zack Weinberg <zackw@panix.com> wrote: >>>> This file was added to sysdeps/generic/bits in 2012. This appears to have >>>> been an oversight, as the entire sysdeps/generic/bits directory was moved to >>>> the top level in 2005. Accordingly the generic bits/hwcap.h belongs there >>>> too. >>>> >>>> ChangeLog: >>>> * sysdeps/generic/bits/hwcap.h: Move to top-level bits/ directory. >>> >>> Looks good to me. >> >> Gonna need someone to check this and any other good-as-is pieces in. > > Ping? I checked in it for you. Please ping again with the patch generated by "git format-patch" if you can't check it in yourself so that people can use "git am" to apply your patch.
diff --git a/bits/hwcap.h b/bits/hwcap.h new file mode 100644 index 0000000..39839ff --- /dev/null +++ b/bits/hwcap.h @@ -0,0 +1,23 @@ +/* Defines for bits in AT_HWCAP. + Copyright (C) 2012-2016 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <http://www.gnu.org/licenses/>. */ + +#ifndef _SYS_AUXV_H +# error "Never include <bits/hwcap.h> directly; use <sys/auxv.h> instead." +#endif + +/* No bits defined for this architecture. */ diff --git a/sysdeps/generic/bits/hwcap.h b/sysdeps/generic/bits/hwcap.h deleted file mode 100644 index 39839ff..0000000 --- a/sysdeps/generic/bits/hwcap.h +++ /dev/null @@ -1,23 +0,0 @@ -/* Defines for bits in AT_HWCAP. - Copyright (C) 2012-2016 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - <http://www.gnu.org/licenses/>. */ - -#ifndef _SYS_AUXV_H -# error "Never include <bits/hwcap.h> directly; use <sys/auxv.h> instead." -#endif - -/* No bits defined for this architecture. */